Project

General

Profile

Bug #6267

Captive Portal Allowed IP Addresses direction not correctly loaded on edit

Added by Stefan Kronawithleitner almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
Start date:
04/26/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Captive Portal "Allowed IP Addresses" (services_captiveportal_ip.php): When specifying direction "to" or "from" and saving, it is displayed correctly. When editing again, the field switches to "both" (and will get saved that way).

Associated revisions

Revision 2aaa473e (diff)
Added by Phillip Davis almost 3 years ago

Fix #6267 Load value of direction on edit

Revision 46f3216e (diff)
Added by Phillip Davis almost 3 years ago

Fix #6267 Load value of direction on edit
(cherry picked from commit 2aaa473e4fab47d1a4f704ebb568f88d59b7ec3e)

History

#1 Updated by Stefan Kronawithleitner almost 3 years ago

Sorry, forgot to include Affected version - this is in 2.3

the corresponding "Allowed Hostnames" site (services_captiveportal_hostname.php) does not have this problem.

#2 Updated by Phillip Davis almost 3 years ago

Setting the existing value on edit seems to have been missed.
PR https://github.com/pfsense/pfsense/pull/2912

#3 Updated by Phillip Davis almost 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#4 Updated by Chris Buechler almost 3 years ago

  • Category set to Captive Portal
  • Status changed from Feedback to Resolved
  • Target version set to 2.3.1
  • Affected Version set to 2.3

works, thanks!

Also available in: Atom PDF