Project

General

Profile

Bug #6582

Import on Firewall/Aliases Only Works for IPs

Added by Daniel Subert over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
07/06/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

In the firewall alias section, the import button only enters values into IP aliases despite the import button being present on all alias types.

I can import other types as long as I don't specify any ranges (using :) which creates an IP alias list that I then have to change to another type and manually enter the missing ranges.

Either the function needs updating to allow other types (mostly port lists) or the import button needs updating so that it only displays on the IP alias page.

Associated revisions

Revision e4c784bf (diff)
Added by Phillip Davis over 3 years ago

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the
Import button is pressed from the IP tab of the firewall_aliases screen.
3) When Import is pressed from the "All" tab of the firewall_aliases
screen, make an IP alias.
4) Do not display the Import button when on the URL tab of the
firewall_aliases screen.

Revision 9461d208 (diff)
Added by Phillip Davis over 3 years ago

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the
Import button is pressed from the IP tab of the firewall_aliases screen.
3) When Import is pressed from the "All" tab of the firewall_aliases
screen, make an IP alias.
4) Do not display the Import button when on the URL tab of the
firewall_aliases screen.

(cherry picked from commit e4c784bfeb5d9bad4c65c421cefb767af0b164dd)

History

#1 Updated by Phillip Davis over 3 years ago

Suggested combination fix and enhancement pull request https://github.com/pfsense/pfsense/pull/3046

#2 Updated by Renato Botelho over 3 years ago

  • Assignee set to Renato Botelho
  • Target version changed from 2.3.1-p6 to 2.3.2

Such a big change for 2.3.1, pushing it to 2.3.2

#3 Updated by Phillip Davis over 3 years ago

Yes, agree. It is new functionality that does not need to risk breaking something in 2.3.1_*

#4 Updated by Steve Beaver over 3 years ago

  • Subject changed from Import on Firewall/Aliases Only Works for IP's to Import on Firewall/Aliases Only Works for IPs

#5 Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Merged, thanks!

#6 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved
  • Affected Version set to All

works

Also available in: Atom PDF