Project

General

Profile

Actions

Bug #6640

closed

DHCPv6 Server Time Format Change Reversed

Added by Daryl Morse over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
DHCP (IPv6)
Target version:
Start date:
07/25/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

The DHCPv6 Server Time Format Change setting "Change DHCPv6 display lease time from UTC to local time" is reversed. When the flag is not set, the time zone is local time. When the flag is set, the time zone is local time - (UTC - local time).

This problem was identified in 2.3.1-RELEASE-p5 (amd64) as well as 2.3.2-DEVELOPMENT (amd64).

Actions #1

Updated by Phillip Davis over 5 years ago

That looks like a bug that has been around for a while - it is not reversed, it is doubled.
If you have the checkbox unchecked, then it adds 1 * time zone offset (when it should make no adjustment)
If you have the checkbox checked, then it adds 2 * time zone offset.

Pull request https://github.com/pfsense/pfsense/pull/3079

Actions #2

Updated by Chris Buechler over 5 years ago

  • Category set to DHCP (IPv6)
  • Status changed from New to Feedback
  • Target version set to 2.3.2-p1
  • Affected Version set to All

merged, thanks Phil

Actions #3

Updated by Daryl Morse over 5 years ago

Phillip Davis wrote:

That looks like a bug that has been around for a while - it is not reversed, it is doubled.
If you have the checkbox unchecked, then it adds 1 * time zone offset (when it should make no adjustment)
If you have the checkbox checked, then it adds 2 * time zone offset.

Pull request https://github.com/pfsense/pfsense/pull/3079

I'm running the yesterday's development snapshot and this problem appears to have been fixed.

Actions #4

Updated by Daryl Morse over 5 years ago

Deleted.

Actions #5

Updated by Jim Pingle about 5 years ago

  • Status changed from Feedback to Resolved

Resolved per above feedback

Actions

Also available in: Atom PDF