Project

General

Profile

Bug #6701

diag_authentication.php related status link

Added by Jeremy C. Reed 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
08/13/2016
Due date:
% Done:

0%

Affected version:
2.3
Affected Architecture:

Description

The diag_authentication "related status" icon links to same page :)

$shortcuts['authentication']['status'] = "diag_authentication.php";

If there is no different status page then remove it.

(My list of bugs is at http://reedmedia.net/books/pfsense/bugs-20160813.html )

Associated revisions

Revision d8d64a57
Added by Steve Beaver 10 months ago

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

Revision e800783e
Added by Steve Beaver 10 months ago

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

History

#1 Updated by Steve Beaver 10 months ago

  • Assignee set to Steve Beaver
  • Target version set to 2.4.0
  • Affected version set to 2.3

Thanks Jeremy,

I'll look at this (and the rest of your list) on the next couple of days.

#2 Updated by Jeremy C. Reed 10 months ago

This is also related:

diag_tables has "Related status" shortcut for "aliases" that
goes to same diag_tables page.
diag_routes and maybe other pages have this too. It was a little
misleading to click through it to realize it was not a
related page. Suggest comparing the target with the link, like
is done for Related settings in shortcuts.inc:

if (!empty($link) && ($_SERVER['REQUEST_URI'] != "/{$link}")) {

(that worked for me)

But maybe there was a reason already this wasn't used?
I didn't notice problem for Related logs, but maybe there too.

#3 Updated by Steve Beaver 10 months ago

  • Project changed from pfSense Packages to pfSense
  • Category set to Web Interface
  • Status changed from New to Resolved
  • Target version changed from 2.4.0 to 2.3.2_1

Also available in: Atom PDF