https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162016-08-16T08:45:00ZpfSense bugtrackerpfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=286192016-08-16T08:45:00ZPhillip Davisphil@jankaritech.com
<ul></ul><p>Looking in the code I found a couple of other things when I did some first looking:<br />1) A problem when specifying DDNS Domain in a static map entry <a class="external" href="https://github.com/pfsense/pfsense/pull/3109">https://github.com/pfsense/pfsense/pull/3109</a><br />2) Duplication of the "option domain-name-servers" line when specified for a pool <a class="external" href="https://github.com/pfsense/pfsense/pull/3110">https://github.com/pfsense/pfsense/pull/3110</a></p>
<p>Stuff like ntp-server and dns-server is only put in the block for the pool if it is different to the overall ntp-server or dns-server for the interface as a whole. So, for example, in the OPs listing above the ntp-server for the pool is specified as 10.10.100.254, the same as for the overall interface, so it is not repeated in the pool. When I put a different value for vthe pool ntp-server then it appears in the config.</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=286222016-08-16T09:55:01ZPhillip Davisphil@jankaritech.com
<ul></ul><p>Please try the code at pull request <a class="external" href="https://github.com/pfsense/pfsense/pull/3112">https://github.com/pfsense/pfsense/pull/3112</a> - /etc/inc/services.inc - and report back if it works for you.</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=286312016-08-17T03:52:11ZHarald Gutmann
<ul></ul><p>Dear Phillip Davis,</p>
<p>many thanks for your fast reaction and fix!<br />I've tested several combinations and can so far confirm that the expected functionality is now there.</p>
<p>The output in the dhcpd.conf looks like this:<br /><pre>
subnet 10.10.100.0 netmask 255.255.255.0 {
pool {
deny members of "001565";
deny members of "00A0BA";
deny members of "000DB9";
range 10.10.100.110 10.10.100.150;
}
pool {
option domain-name-servers 8.8.8.8;
allow members of "001565";
option domain-name-servers 8.8.8.8;
option ntp-servers at.pool.ntp.org;
option custom-opt8-0-0 "http://10.10.100.100/yealink/";
range 10.10.100.1 10.10.100.99;
}
pool {
option domain-name-servers 8.8.8.8;
allow members of "00A0BA";
option domain-name-servers 8.8.8.8;
option custom-opt8-1-0 "http://10.10.100.100/patton_gw/";
range 10.10.100.102 10.10.100.103;
}
option routers 10.10.100.254;
option domain-name-servers 10.10.100.254;
option ntp-servers 10.10.100.254;
option custom-opt8-0 "http://10.10.100.100/general/";
}
</pre></p>
I've noticed the following flaws:
<ul>
<li> domain-name-servers are listed twice. All other options I tried are only listed once in the sub-pools.</li>
<li> indentation of option custom-optX-Y-Z does not match the blocks.</li>
</ul>
<p>Again, many thanks for your support!</p>
<p>Best regards,<br />Harald Gutmann</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=286382016-08-17T17:46:35ZPhillip Davisphil@jankaritech.com
<ul></ul><p>1) "domain-name-servers are listed twice" - yeh, I noticed that also. Should be fixed by pull request <a class="external" href="https://github.com/pfsense/pfsense/pull/3110">https://github.com/pfsense/pfsense/pull/3110</a></p>
<p>2) I added an extra tab of indent to PR 3112</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=286422016-08-18T04:29:05ZHarald Gutmann
<ul></ul><p>I've just tested PR3112 including the 2nd commit & PR3110.<br />The result is now perfect, functionallity is there & the config file looks clean.</p>
<p>I think we can consider this as done when the according pull request are merged.</p>
<p>Many many thanks for your efforts to fix this issue.</p>
<p>Best Regards,<br />Harald Gutmann</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=287352016-08-29T13:05:57ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul><p>Pull request has been merged. Thanks!</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=287362016-08-29T13:10:11ZPhillip Davisphil@jankaritech.com
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fix #6720 DHCP options by pool It is a little bit tricky having to generate the unique "option c..." href="https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/285987208f31f38abe35b984b08645d43c11b001">285987208f31f38abe35b984b08645d43c11b001</a>.</p> pfSense - Bug #6720: DHCPD Options in "Sub-"Pools ignored, dhcpd.conf does not contain informations, dhcpd therefore not servinghttps://redmine.pfsense.org/issues/6720?journal_id=289312016-09-23T10:22:11ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Fixed, per above feedback</p>