Project

General

Profile

Bug #6806

Form validation for DHCP NTP Servers does not allow hyphens

Added by Edward Hurtig 10 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Category:
Dashboard
Target version:
Start date:
09/21/2016
Due date:
% Done:

100%

Affected version:
2.3.2
Affected Architecture:

Description

Form validation in the dashboard does not use the proper regex for FQDNs (it doesn't allow hyphens)

<input class="form-control" name="ntp2" id="ntp2" value="1.north-america.pool.ntp.org" pattern="[.a-zA-Z0-9_]+" type="text">

While we're on it, the underscore should probably be removed as underscores are not allowed in hostnames or FQDNs (RFC 1123)

<input class="form-control" name="ntp2" id="ntp2" value="1.north-america.pool.ntp.org" pattern="[.a-zA-Z0-9-]+" type="text">

Screenshot from 2016-09-22 00-32-38.png (8.47 KB) Edward Hurtig, 09/21/2016 11:33 PM

Associated revisions

Revision c68dbfc7
Added by Eddie Hurtig 10 months ago

Allow Hyphens in DHCP NTP Server form validation

Also removes the ability to have underscores `_` in ntp server
FQDNs.

Closes #6806

Revision 87fb4454
Added by Eddie Hurtig 10 months ago

Allow Hyphens in DHCP NTP Server form validation

Also removes the ability to have underscores `_` in ntp server
FQDNs.

Closes #6806

(cherry picked from commit c68dbfc7580180cd9d47bdbecaeeb6cf835fe210)

History

#1 Updated by Edward Hurtig 10 months ago

https://github.com/pfsense/pfsense/pull/3151 (CLA was just signed so might not be labeled appropriately yet)

#2 Updated by Anonymous 10 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle 6 months ago

  • Assignee set to Edward Hurtig
  • Target version set to 2.3.3

#4 Updated by Renato Botelho 6 months ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF