Project

General

Profile

Actions

Bug #7139

closed

User with some pages plus Help cannot use page help

Added by Phillip Davis about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Dashboard
Target version:
Start date:
01/19/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

1) Create a new user "u1". Give the user some page privs (e.g. Services-DHCP) plus "Help - all pages".
2) Logout of admin and login as "u1".
3) Go to Services-DHCP
4) Click the "?" to get help.

Actual Behavior: A new tab opens, flickers a bit and goes back to displaying the default page of "u1".

Expected behavior: A new tab opens, and directs to the relevant help page.

Actions #1

Updated by Phillip Davis about 7 years ago

The "?" or the Help menu item "About this page" point to a URL like:
help.php?page=services_dhcp.php

The code that determines isPageAllowed only allows just help.php - but it should allow help.php*

PR https://github.com/pfsense/pfsense/pull/3400

Actions #2

Updated by Phillip Davis about 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Jim Pingle about 7 years ago

  • Status changed from Feedback to Resolved

Works, thanks!

Actions #4

Updated by Jim Pingle about 7 years ago

  • Target version changed from 2.4.0 to 2.3.3
Actions

Also available in: Atom PDF