Project

General

Profile

Bug #7171

system_advanced_firewall.php: setHelpText is changing the field label also.

Added by Phillip Davis 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Web Interface
Target version:
Start date:
01/30/2017
Due date:
% Done:

100%

Affected version:
2.4
Affected Architecture:

Description

I suspect this is a side-effect of the recent changes for marking required fields.
e.g. in system_advanced_firewall.php as you change the selected item in the "Firewall Optimization Options" field, the help text changes, but the field name also gets set to the help text.
See attached GIF.

AdvFirewallOptimization.gif (178 KB) Phillip Davis, 01/30/2017 04:16 AM

Associated revisions

Revision 678c6a56
Added by Steve Beaver 6 months ago

Fixed #7171
Moved setHelpText() to helpers file

History

#1 Updated by Steve Beaver 6 months ago

  • Subject changed from setHelpText is changing the field label also. to system_advanced_firewall.php: setHelpText is changing the field label also.

#2 Updated by Steve Beaver 6 months ago

  • Status changed from New to Feedback

Newly added span element accommodated
Function moved to pfSenseHelpers.js

#3 Updated by Steve Beaver 6 months ago

  • % Done changed from 0 to 100

#4 Updated by Phillip Davis 6 months ago

Works, thanks

#5 Updated by Steve Beaver 6 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF