Bug #7237
closed
ACME - first table row on certs tab does not autoexpand the fields
0%
Description
In the Domain SAN list, the first row in the table does not auto-expand the fields with required settings. See screenshot -- local webroot method shown there, but it's the exact same behavior with any other method.)
Updated by Kill Bill about 7 years ago
Also, apparently there's lack of input validation here (i.e., at least those fields should be required so that people are forced to fill those in). Otherwise, it results in cryptic error messages such as those shown @ https://forum.pfsense.org/index.php?topic=125293.0
Updated by Jim Pingle about 7 years ago
- Category set to ACME
- Status changed from New to Confirmed
- Assignee set to Jim Pingle
- Affected Version set to All
- Affected Architecture All added
- Affected Architecture deleted (
)
The input validation does need work but it's going to be rather complex to pull off. That should probably be a separate bug yet.
As for this one, the field is hidden by default apparently on purpose. I've been testing a few things out in /usr/local/pkg/acme/acme_htmllist.inc (Line 301, remove 'hidden' from the class attribute) but haven't found a good combination. Either the fields are all exposed until one is chosen or it's a bit more work to try figuring out the initial state.
Updated by Kill Bill about 7 years ago
Well yeah, the thing is not exactly simple readable code :D Being hidden wouldn't really be much of an issue if people were forced to fill in something, that'd make them pay more attention to the GUI, now it's just saved and doesn't work after that.
Updated by Pi Ba about 7 years ago
Should get fixed/changed with this: https://github.com/pfsense/FreeBSD-ports/pull/329
Updated by Jim Pingle almost 7 years ago
- Status changed from Confirmed to Resolved
This has been fixed for a while now