Project

General

Profile

Bug #7572

openvpn client resolv-retry infinite issues

Added by Jeremy C. Reed 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OpenVPN
Target version:
Start date:
05/20/2017
Due date:
% Done:

100%

Affected version:
All
Affected Architecture:
All

Description

vpn_openvpn_client.php and /etc/inc/openvpn.inc
Has checkbox to enable "Infinitely resolve server"
but the resolv-retry infinite config is used also if is a client. This is a client.

In addition, OpenVPN 2.3 has this enabled
by default. I don't see anything here to set it to 0 (zero) to
disable.

To explain a different way, the config.xml has:
<resolve_retry></resolve_retry> while the openvpn$NUM.conf still has:
"resolv-retry infinite".

I suggest getting rid of it of the feature since is default behavior
and is always set here.

Or if you keep make it so unchecked means is "0" and don't set by
default for client too.

(I noticed this while working on my book.
My list of bugs is at http://reedmedia.net/books/pfsense/bugs.html )

Associated revisions

Revision 919a0f4a
Added by Jim Pingle 4 months ago

The logic for resolv-retry infinite was always setting it in client mode no matter what the GUI option wanted. Remove the GUI option and clean up the logic so it isn't duplicated. Fixes #7572

History

#1 Updated by Jim Pingle 4 months ago

  • Category changed from VPN to OpenVPN
  • Status changed from New to Assigned
  • Assignee set to Jim Pingle
  • Target version set to 2.4.0
  • Affected version set to All
  • Affected Architecture set to All

Looks like we can remove it since it's been forced on for clients for some time now (~3 years).

#2 Updated by Jim Pingle 4 months ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF