https://redmine.pfsense.org/https://redmine.pfsense.org/favicon.ico?16780521162018-09-13T20:50:01ZpfSense bugtrackerpfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=383642018-09-13T20:50:01ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Not a Bug</i></li><li><strong>Target version</strong> deleted (<del><i>2.4.4</i></del>)</li><li><strong>Affected Version</strong> deleted (<del><i>2.4.3_1</i></del>)</li></ul><p>It's done deliberately to avoid long aliases preventing wrapping. <a class="issue tracker-1 status-3 priority-4 priority-default closed" title="Bug: firewall_rules.php & firewall_nat.php: Replaces underscores with spaces in aliase names (Resolved)" href="https://redmine.pfsense.org/issues/7249">#7249</a></p> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=383662018-09-13T20:58:43Z→ luckman212luke.hamburg@gmail.com
<ul></ul><p>The change above substitutes '_' with '_<wbr>' which is the same method used on other NAT pages. The '<wbr>' signals that it's ok for the browser to break there and so it allows wrapping to happen while still preserving the underscores. This seems like the right thing to me.<br /><a class="external" href="https://github.com/pfsense/pfsense/pull/3980#issuecomment-421350916">https://github.com/pfsense/pfsense/pull/3980#issuecomment-421350916</a><br /><img src="https://user-images.githubusercontent.com/1992842/45551607-7eb17200-b7fc-11e8-917a-7bf7065aa36b.png" alt="" /></p> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=383742018-09-14T12:08:18ZJim Pingle
<ul><li><strong>Status</strong> changed from <i>Not a Bug</i> to <i>New</i></li><li><strong>Target version</strong> set to <i>2.4.4-GS</i></li><li><strong>Affected Version</strong> set to <i>2.4.x</i></li><li><strong>Affected Architecture</strong> <i>All</i> added</li><li><strong>Affected Architecture</strong> deleted (<del><i></i></del>)</li></ul><p>You are right that one page is inconsistent with the rest. They should all be done the same way. Not going to hold back 2.4.4 for a minor change like this though.</p> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=385832018-09-26T14:55:38ZRenato Botelhorenato@netgate.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Renato Botelho</i></li></ul><p>PR merged</p> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=386852018-10-01T17:07:09ZSteve Wheeler
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Looks good.</p>
<p>Tested in:</p>
<pre>
2.4.5-DEVELOPMENT (amd64)
built on Mon Oct 01 01:24:24 EDT 2018
FreeBSD 11.2-RELEASE-p4
</pre> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=387762018-10-03T08:51:13ZAnonymous
<ul><li><strong>Target version</strong> changed from <i>2.4.4-GS</i> to <i>2.4.4-p1</i></li></ul> pfSense - Bug #8893: Outbound NAT page unnecessarily strips underscores from alias nameshttps://redmine.pfsense.org/issues/8893?journal_id=387882018-10-03T09:07:19ZAnonymous
<ul><li><strong>Target version</strong> changed from <i>2.4.4-p1</i> to <i>2.4.4-GS</i></li></ul>