Project

General

Profile

Bug #8962

firewall_rules.edit.php: Double quotes in Gateway description cause blank gateway drop-down

Added by Jim Pingle over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
09/26/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
All
Affected Architecture:
All

Description

A gateway description with double quotes breaks the JSON used to form the gateway drop-down options, resulting in a blank gateway list.

Easy to replicate, set the description for any gateway to blah "blah" blah.

It is encoded safely but still results in invalid JSON.

To me, I have a fix.

Associated revisions

Revision 157aff9e (diff)
Added by Jim Pingle over 2 years ago

Fix JSON encoding of gw/gwg params for firewall rule gw list. Fixes #8962

Revision 1c28902c (diff)
Added by Jim Pingle over 2 years ago

Fix JSON encoding of gw/gwg params for firewall rule gw list. Fixes #8962

(cherry picked from commit 157aff9e256aa235ba68ccc2168c61fc61e90072)

History

#1 Updated by Jim Pingle over 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Steve Wheeler over 2 years ago

  • Status changed from Feedback to Resolved

Fixed in:

2.4.5-DEVELOPMENT (amd64)
built on Mon Oct 01 01:24:24 EDT 2018
FreeBSD 11.2-RELEASE-p4

Set gateway description as 'Interface "WAN_DHCP" Gateway'. Does not appear the firewall drop-down in 2.4.4. Prevents 'Default' showing even. Works in 2.4.5.

#3 Updated by Steve Beaver over 2 years ago

  • Target version changed from 2.4.4-GS to 2.4.4-p1

#4 Updated by Steve Beaver over 2 years ago

  • Target version changed from 2.4.4-p1 to 2.4.4-GS

Also available in: Atom PDF