Bug #8966
closed
Patches page uses GET instead of POST when performing actions
0%
Description
When the patches page system_patches.php is used to apply or revert a patch, the link in the cookie trail area of that page (System / Patches) changes to be the URL that will apply or revert the patch that was just replied or reverted (e.g. https://192.168.45.1/system_patches.php?id=0&act=apply). If you click on that link it will attempt to apply/revert the patch again, which will, of course fail.
The URL in the cookie area of the page should always be just the patches page without any actions: https://192.168.45.1/system_patches.php
Updated by Jim Pingle over 5 years ago
- Project changed from pfSense to pfSense Packages
- Subject changed from Patches page cookie trail link includes the apply/revert action to Patches page uses GET instead of POST when performing actions
- Category changed from Package System to System Patches
- Assignee set to Jim Pingle
- Affected Architecture All added
- Affected Architecture deleted (
)
Updated by Jim Pingle over 5 years ago
- Status changed from New to Feedback
Fixed in System Patches v1.2, which will show up shortly.
Updated by Anonymous over 5 years ago
I'm not entirely sure this related, but I just upgraded a system to 2.4.4 which picked up the new System Patches v1.2 package. Now I'm getting:
Crash report begins. Anonymous machine information:
amd64
11.2-RELEASE-p3
FreeBSD 11.2-RELEASE-p3 #17 e6b497fa0a3(RELENG_2_4_4): Thu Sep 20 09:04:45 EDT 2018 root@buildbot3:/crossbuild/ce-244/obj/amd64/WvDslnYb/crossbuild/ce-244/pfSense/tmp/FreeBSD-src/sys/pfSense
Crash report details:
PHP Errors:
[27-Sep-2018 23:40:33 UTC] PHP Fatal error: Uncaught Error: Cannot create references to/from string offsets in /usr/local/www/system_patches.php:37
Stack trace:
#0 {main}
thrown in /usr/local/www/system_patches.php on line 37
No FreeBSD crash data found.
Updated by Jim Pingle over 5 years ago
Yeah that was due to a syntax error I made in the previous commit. Fix has been pushed, update and try again
Updated by Anonymous over 5 years ago
It seems to be fixed now. Thanks for the quick turnaround.
Updated by Renato Botelho over 5 years ago
- Status changed from Feedback to Resolved