Project

General

Profile

Bug #8966

Patches page uses GET instead of POST when performing actions

Added by Mitch Claborn almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
System Patches
Target version:
-
Start date:
09/27/2018
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4.3_1
Affected Architecture:
All

Description

When the patches page system_patches.php is used to apply or revert a patch, the link in the cookie trail area of that page (System / Patches) changes to be the URL that will apply or revert the patch that was just replied or reverted (e.g. https://192.168.45.1/system_patches.php?id=0&act=apply). If you click on that link it will attempt to apply/revert the patch again, which will, of course fail.

The URL in the cookie area of the page should always be just the patches page without any actions: https://192.168.45.1/system_patches.php

History

#1 Updated by Jim Pingle almost 2 years ago

  • Project changed from pfSense to pfSense Packages
  • Subject changed from Patches page cookie trail link includes the apply/revert action to Patches page uses GET instead of POST when performing actions
  • Category changed from Package System to System Patches
  • Assignee set to Jim Pingle
  • Affected Architecture All added
  • Affected Architecture deleted ()

#2 Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Feedback

Fixed in System Patches v1.2, which will show up shortly.

#3 Updated by Anonymous almost 2 years ago

I'm not entirely sure this related, but I just upgraded a system to 2.4.4 which picked up the new System Patches v1.2 package. Now I'm getting:

Crash report begins.  Anonymous machine information:

amd64
11.2-RELEASE-p3
FreeBSD 11.2-RELEASE-p3 #17 e6b497fa0a3(RELENG_2_4_4): Thu Sep 20 09:04:45 EDT 2018     root@buildbot3:/crossbuild/ce-244/obj/amd64/WvDslnYb/crossbuild/ce-244/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[27-Sep-2018 23:40:33 UTC] PHP Fatal error:  Uncaught Error: Cannot create references to/from string offsets in /usr/local/www/system_patches.php:37
Stack trace:
#0 {main}
  thrown in /usr/local/www/system_patches.php on line 37

No FreeBSD crash data found.

#4 Updated by Jim Pingle almost 2 years ago

Yeah that was due to a syntax error I made in the previous commit. Fix has been pushed, update and try again

#5 Updated by Anonymous almost 2 years ago

It seems to be fixed now. Thanks for the quick turnaround.

#6 Updated by Renato Botelho almost 2 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF