Project

General

Profile

Bug #9097

ECL can't locate config.xml unless device is MBR-partitioned

Added by Adam Thompson 7 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Installer
Target version:
-
Start date:
11/05/2018
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4.4
Affected Architecture:

Description

Follow-on to #9089, but this one needs to be fixed in code, IMHO:

  • GPT devices show up as da1p1, not da1s1, so can't be used for ECL

(FYI: macOS's Disk Utility now formats devices as GPT by default, not MBR. Yay.)

The fix appears to be trivial, although I lack the skills and infrastructure to build - and thus test - this fix (sorry). I'd be happy to test a fresh spin of the install ISO, though, if you provide a URL.

I'm not too sure about git-diff's output here, but you can see the gist of the 1-line change regardless.

diff --git a/src/etc/ecl.php b/src/etc/ecl.php
index 30a64c5d43..05d519c952 100755
--- a/src/etc/ecl.php
+++ b/src/etc/ecl.php
@@ -37,7 +37,7 @@ function get_swap_disks() {

 function get_disk_slices($disk) {
        global $g, $debug;
-       $slices = glob("/dev/" . $disk . "s*");
+       $slices = glob("/dev/" . $disk . "[ps]*");
        $slices = str_replace("/dev/", "", $slices);
        return $slices;
 }

Also available in: Atom PDF