Project

General

Profile

Actions

Bug #9348

open

Results of ACME certificate issuance/renewal are not properly formatted

Added by Isaac McDonald over 7 years ago. Updated 19 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
ACME
Target version:
-
Start date:
02/22/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
Affected Plus Version:
Affected Architecture:

Description

The results of an Acme certificate issuance/renewal aren't properly formatted. Even when there are no errors the results look like a core dump which diminishes confidence in the quality of this plugin.

Steps to reproduce:
1. Navigate to services ---> Acme Certificates
2. Click Add
3. Enter a name for the certificate and use foo.example.com as the domain name in the SAN list.
4. Use a DNS update method such as "DNS-NSUpdate / RFC 2136" or "DNS-ClouDNS" and enter bogus information
5. Click Save
6. Click "Issue renew" next to the certificate you just created.
7. Note the results of the cert issuance/renewal aren't properly formatted

See attached screenshot.


Files

acme.jpg (191 KB) acme.jpg Screenshot depicting improper formatting Isaac McDonald, 02/22/2019 11:21 AM
Actions #1

Updated by Jim Pingle 23 days ago

  • Subject changed from Results of Acme certificate issuance/renewal are not properly formatted to Results of ACME certificate issuance/renewal are not properly formatted
  • Assignee set to Jim Pingle
Actions #2

Updated by Jim Pingle 23 days ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Fixed in ACME pkg v1.3.1

Added basic successs/fail detection to the output box in the GUI so it gets an appropriate color based on the result

The verboseness of the logs is covered by #12670

Actions #3

Updated by Jim Pingle 19 days ago

  • Status changed from Feedback to In Progress
  • % Done changed from 100 to 90

There is still one little bug with this, if the log contains both "success" and one of the failure messages, it still appears green. It needs to remove the alert-success class when it detects an error message. Also it should consider "timeout" an error.

Actions #4

Updated by Jim Pingle 19 days ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100

Fixed in ACME pkg v1.3.2

Actions

Also available in: Atom