Project

General

Profile

Actions
Copy link

Bug #9449

closed

Empty lines in various forms

Added by Peter Feichtinger over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Web Interface
Target version:
2.5.0
Start date:
04/03/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

I noticed a couple of empty lines in some forms, which are caused by using addInput instead of addGlobal to add hidden form inputs.
The linked PR fixes them, along with a small logic error introduced during Bootstrap conversion.

PR: https://github.com/pfsense/pfsense/pull/4060

Actions
Copy link
 #1

Updated by Jim Pingle over 5 years ago

  • Affected Version set to All
  • Affected Architecture All added
  • Affected Architecture deleted ()
Actions
Copy link
 #2

Updated by Renato Botelho over 5 years ago

  • Status changed from New to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions
Copy link
 #3

Updated by A FL over 5 years ago

Hello,

One question : this issue is similar to #9221 ( https://github.com/pfsense/pfsense/pull/4057 )

Is PR 4057 still required? Should #9221 be marked as duplicate ?

Actions
Copy link
 #4

Updated by Jim Pingle almost 5 years ago

  • Status changed from Feedback to Resolved

Looks good, no more blank areas like there were before.

Actions
Copy link

Also available in: Atom PDF