Project

General

Profile

Feature #9693

Bypass automatic backups

Added by Steve Beaver 11 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Backup / Restore
Target version:
Start date:
08/21/2019
Due date:
% Done:

100%

Estimated time:

Description

If the reason/description string of a config back contains the string "-NoReMoTeBaCkUp" no ACB will be performed. The string is removed before the local config file is changed.

This is to allow packages such as Snort and pfBlockerNG to write to config.xml without hammering the ACB system.

E.g.:

   write_config("Just making a little change-NoReMoTeBaCkUp");

Will cause the configuration change description "Just making a little change" to be recorded. NO ACB will be performed.

Associated revisions

Revision 6f6299a3 (diff)
Added by Steve Beaver 11 months ago

Fixed #9693
Allow ACB to be suppressed by including magic string in the backup description
Transmit max number of manual backups in the ACB

Revision 3184695e (diff)
Added by Steve Beaver 10 months ago

Fixed #9693
Allow ACB to be suppressed by including magic string in the backup description
Transmit max number of manual backups in the ACB

(cherry picked from commit 6f6299a3a6aca1b7baf5d80d6d24325100363939)

History

#1 Updated by Steve Beaver 11 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Anonymous 10 months ago

  • Status changed from Feedback to Resolved

Tested on 2.5.0.a.20190830.1941, works as expected.

#3 Updated by Gerwim F 10 months ago

James Dekker wrote:

Tested on 2.5.0.a.20190830.1941, works as expected.

There's a typo on line 190 (in src/etc/inc/acb.inc):

function upload_config($manual = flase) {

flase should be false

#4 Updated by Jim Pingle 10 months ago

  • Status changed from Resolved to New

#5 Updated by Steve Beaver 10 months ago

  • Status changed from New to Closed

This was fixed moments after the original push

#6 Updated by Jim Pingle 7 months ago

  • Target version changed from 2.5.0 to 2.4.5

#7 Updated by Jim Pingle 7 months ago

  • Status changed from Closed to Feedback

Needs checked and/or tested again on 2.4.5 snapshots

#8 Updated by Jim Pingle 7 months ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Steve Beaver to Jim Pingle

Manual backups with a reason entered by the user aren't getting the correct string appended, so MaNuAlBaCkUp is showing through in the backup list when it shouldn't be. It's an easy fix, I'll take care of it.

#9 Updated by Jim Pingle 7 months ago

  • Status changed from In Progress to Feedback
  • Assignee changed from Jim Pingle to Steve Beaver

Cherry picked 0bdd1774a1666852e35452ea3f17bb9dc075ecec which fixed it on master.

I tested the NoReMoTeBaCkUp string as well and it behaved as expected.

#10 Updated by Jim Pingle 6 months ago

  • Status changed from Feedback to Resolved

Looks good now.

Also available in: Atom PDF