Project

General

Profile

Bug #9840

PHP7: Uninitialised array in upgrade_config.inc

Added by Steve Wheeler 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Upgrade
Target version:
Start date:
10/21/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.4-p3
Affected Architecture:
All

Description

Interfaces set to trackv6 against an interface that does not have an IPv6 config trigger this:

Crash report begins.  Anonymous machine information:

amd64
11.2-RELEASE-p10
FreeBSD 11.2-RELEASE-p10 #9 10fea60fdde(factory-RELENG_2_4_4): Thu May 16 06:55:01 EDT 2019     root@buildbot1-nyi.netgate.com:/build/factory-crossbuild-244/obj/amd64/bwlyKhYx/build/factory-crossbuild-244/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[16-Oct-2019 19:02:34 Etc/UTC] PHP Fatal error:  Uncaught Error: Cannot use string offset as an array in /etc/inc/upgrade_config.inc:4577
Stack trace:
#0 /etc/inc/config.lib.inc(378): upgrade_144_to_145()
#1 /etc/rc.bootup(125): convert_config()
#2 {main}
  thrown in /etc/inc/upgrade_config.inc on line 4577

It's not normally possible hit this as current versions prevent configuring it. In this case it was a 2.2 config that hit it.

Associated revisions

Revision 8e0d33ec (diff)
Added by Jim Pingle 4 months ago

Initialize array to avoid a PHP error in upgrade_144_to_145(). Fixes #9840

Revision dc9393ba (diff)
Added by Jim Pingle 4 months ago

Initialize array to avoid a PHP error in upgrade_144_to_145(). Fixes #9840

(cherry picked from commit 8e0d33ec48792e13839a0181031664261269c220)

History

#1 Updated by Jim Pingle 4 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Jim Pingle 3 months ago

  • Target version changed from 2.5.0 to 2.4.5

#3 Updated by Viktor Gurov 2 months ago

tested on pfSense 2.4.5.a.20191209.0732

no any crash reports
Resolved

#4 Updated by Jim Pingle 2 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF