Project

General

Profile

Bug #9938

Queue stats parser broken if bytes > 9999999999

Added by Lucas Held 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

Hello,
currently the queue stats parser in the file "/etc/inc/shaper.inc" assumes that the bytes value does not exceed the length of 10. If this limit is exceed the page "/status_queues.php" displays wrong values. After a filter reload the bytes value is reset and the values are correct for a few minutes until the bytes value is too large again.

Decisive line from "/sbin/pfctl -s queue -v" output
Displays correct:

'  [ pkts:    6653183  bytes: 9993145948  dropped pkts:      0 bytes:      0 ]'

Displays incorrect:
'  [ pkts:    6661877  bytes: 10006205865  dropped pkts:      0 bytes:      0 ]'

History

#1 Updated by Jim Pingle 6 months ago

  • Due date deleted (12/01/2019)
  • Status changed from New to Pull Request Review
  • Start date deleted (12/01/2019)
  • Estimated time deleted (1.00 h)
  • Affected Version changed from 2.4.4-p3 to All

#3 Updated by Renato Botelho 6 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee changed from Lucas Held to Renato Botelho
  • Target version changed from 2.5.0 to 2.4.5

PR has been merged. Thanks!

#4 Updated by Chris Linstruth 5 months ago

Status_queues looks fine here:

[ pkts:   90492841  bytes: 71051952021  dropped pkts:  82974 bytes: 62613863 ]
[ qlength: 0/ 50 ]

#5 Updated by Jim Pingle 5 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF