Project

General

Profile

Activity

From 10/22/2015 to 11/20/2015

11/20/2015

07:35 AM Todo #5439 (Resolved): Revise installed package widget and page
Renato Botelho
01:40 AM Bug #5459 (Resolved): system_advanced_sysctl.php lacking input validation, output sanitation
looks good, thanks! Chris Buechler
01:03 AM Bug #5482 (Resolved): Hard disk standby time missing
works, thanks! Chris Buechler
12:56 AM Todo #5478 (Resolved): Page title text duplication
looks good Chris Buechler
12:55 AM Bug #5450 (Resolved): GUI issues in IE on DNS Resolver and Forwarder
yeah that does it, looks good Chris Buechler
12:36 AM Bug #5490 (Resolved): bad validation on system_usermanager_settings.php
fixed Chris Buechler
06:50 PM Bug #5490: bad validation on system_usermanager_settings.php
Applied in changeset pfsense:commit:e6d97c6e14f21fc1160dc47a53a97328583c87ae. Steve Beaver
06:43 PM Bug #5490 (Feedback): bad validation on system_usermanager_settings.php
Numeric input limit set to zero.
The error message printed when the test is not performed was in the wrong place s...
Steve Beaver

11/19/2015

05:24 PM Bug #5490 (Resolved): bad validation on system_usermanager_settings.php
it says "Enter 0 to never expire sessions." but forces you to enter a number greater than 0.
Also "Save" and "Save...
Jared Dillard
02:53 PM Bug #5470 (Resolved): Dashboard needs Breadcrumb
Thanks Steve! Jared Dillard
07:14 AM Bug #5470: Dashboard needs Breadcrumb
Breadcrumbs provided. Steve Beaver
11:50 AM Todo #5478 (Feedback): Page title text duplication
Applied in changeset pfsense:commit:1908003a5163d8acd29cd89ab901718caca0b645. Anonymous
11:44 AM Todo #5478: Page title text duplication
I can't change the status to Feedback, but I committed CSS changes that removes the first line and make the 2nd line ... Jared Dillard
07:17 AM Todo #5478: Page title text duplication
Breadcrumbs are now generated on index.php allowing their display to be controlled by CSS.
Re-assigning to JDillard.
Steve Beaver
10:03 AM Bug #5486 (Resolved): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Works now, thanks! Jim Pingle
10:00 AM Bug #5486: firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Applied in changeset pfsense:commit:c2e566f479297257b94b5318aba6458c299d2d65. Steve Beaver
09:52 AM Bug #5486 (Feedback): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Fixed Steve Beaver
09:35 AM Bug #5486 (Resolved): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
On firewall_nat.php when you drag and drop to reorder rules, then click save, the order is not stored. The page refre... Jim Pingle
09:11 AM Bug #5450 (Feedback): GUI issues in IE on DNS Resolver and Forwarder
It seems that some versions of IE doesn't like tables that have an empty <tbody>. Those are now detected via jQuery a... Steve Beaver
07:38 AM Bug #5459 (Feedback): system_advanced_sysctl.php lacking input validation, output sanitation
Kinder, gentler version now saves: "'>alert("hi");" by using strip_tags rather than htmlspecialchars Steve Beaver
06:57 AM Bug #5482 (Feedback): Hard disk standby time missing
Steve Beaver
01:37 AM Bug #5482 (Resolved): Hard disk standby time missing
system_advanced_misc.php used to have the "Hard disk standby time" configuration option.
https://github.com/pfsense...
Chris Buechler
06:50 AM Bug #5463 (Resolved): Cannot mark notices as read.
Steve Beaver
06:15 AM Bug #5463: Cannot mark notices as read.
Confirmed. Working fine with this mornings update in FF42 in Mint. Steve Wheeler
05:20 AM Bug #5463: Cannot mark notices as read.
Steve Wheeler - Can you confirm please? Steve Beaver
11:10 PM Bug #5463: Cannot mark notices as read.
Also worked for me afterwards. I merged Phil's pull request to double check without the debug, and it's fine.
Wil...
Chris Buechler
10:03 PM Bug #5463: Cannot mark notices as read.
That works in Firefox 38.4.0 and Google Chrome. Both using the UI and "closenotice=all" is good.
I can take the "nor...
Phillip Davis
06:14 PM Bug #5463: Cannot mark notices as read.
Added some debbuging. You should get an alert on clicking the Clear button, and another when thee notices have been c... Steve Beaver
06:11 AM Bug #5475 (Resolved): Gateways Dashboard widget should dynamically update
Steve Beaver
11:38 PM Bug #5475: Gateways Dashboard widget should dynamically update
and I just added another commit to that PR 2086 to remove some duplicated code that had snuck into master somewhere a... Phillip Davis
09:34 PM Bug #5475: Gateways Dashboard widget should dynamically update
https://github.com/pfsense/pfsense/pull/2086
$display_type var setting needs to be earlier.
Phillip Davis
09:16 PM Bug #5475: Gateways Dashboard widget should dynamically update
I should always look for regressions also! JimP is correct - monitor IP has gone AWOL, even on first display. Phillip Davis
09:02 PM Bug #5475: Gateways Dashboard widget should dynamically update
Works for me - thanks. Phillip Davis
08:59 PM Bug #5475 (Assigned): Gateways Dashboard widget should dynamically update
Updates OK but now it doesn't display the monitor IP. Jim Pingle

11/18/2015

05:14 PM Bug #5310 (Resolved): Wizard error page not correctly formatted
fixed Chris Buechler
05:09 PM Bug #5380 (Resolved): setup wizard timezone should default to GMT
fixed Chris Buechler
04:30 PM Bug #5463: Cannot mark notices as read.
Still not working for me in FF42 on Mint. Updated to latest code and Gitsynced to Master. Steve Wheeler
03:58 PM Bug #5463: Cannot mark notices as read.
Same with Firefox 41 and 42 on Windows, including in FF safe mode. Chris Buechler
11:24 AM Bug #5463: Cannot mark notices as read.
If this continues to be a problem, I'll add some debug to help you track it down. Let's see what feedback we get from... Steve Beaver
11:23 AM Bug #5463: Cannot mark notices as read.
Works for me now in FF where it did not work before. On a current snap + gitsync though. Jim Pingle
10:51 AM Bug #5463: Cannot mark notices as read.
This still does not work for me in Firefox 38.4.0ESR.
I tried ctrl-F5 to (hopefully) reload any cached JS or...
It ...
Phillip Davis
04:14 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
Dug an old laptop out of the basement and was able to reproduce. Also tested a work-around that seems effective. I wi... Steve Beaver
02:57 AM Bug #5450 (Confirmed): GUI issues in IE on DNS Resolver and Forwarder
This happens on services_dnsmasq.php as well as the unbound pages described using IE with compatibility mode disabled... Chris Buechler
04:02 PM Bug #5311 (Resolved): vpn_openvpn_*.php: export tabs not installed after installing openvpn client export package
fixed Chris Buechler
03:59 PM Bug #5412 (Resolved): Missing alias autocomplete on firewall_nat_edit.php source field
fixed Chris Buechler
03:58 PM Bug #5479 (Resolved): Dashboard widget control icons no longer flush right
Noted :) I don't think this one was related to my changes, but it is fixed now regardless.
https://github.com/pfsens...
Jared Dillard
10:40 AM Bug #5479: Dashboard widget control icons no longer flush right
And related to the icons going AWOL for the last 16 hours or so - https://forum.pfsense.org/index.php?topic=102617.0
...
Phillip Davis
10:34 AM Bug #5479 (Feedback): Dashboard widget control icons no longer flush right
I think this was a JDillard experiment ? Steve Beaver
10:33 AM Bug #5479 (Resolved): Dashboard widget control icons no longer flush right
Some time in the last two days the widget icons stopped being aligned to the right upper corner:
!http://i.imgur.c...
Jim Pingle
03:45 PM Bug #5462 (Resolved): In diag_routes.php the top section is incorrectly labelled Traceroute
fixed Chris Buechler
03:15 PM Todo #5478: Page title text duplication
check out the dark theme, I hid the first line and made the breadcrumbs a larger font. This is the reason I want the ... Jared Dillard
03:04 PM Todo #5478: Page title text duplication
Is there any situation in which the page title isn't contained in the breadcrumbs? Chris Buechler
06:54 AM Todo #5478: Page title text duplication
The first line is the page title. (What this page does)
The second line contains the breadcrumbs (how we got here)
...
Steve Beaver
03:16 AM Todo #5478 (Resolved): Page title text duplication
Pages have their title displayed twice right next to each other, which is redundant and chews up screen space unneces... Chris Buechler
01:13 PM Bug #5470: Dashboard needs Breadcrumb
It is best for styling consistency, otherwise it is odd man out and you have to make special styling rules for it. Jared Dillard
01:12 PM Bug #5470 (Feedback): Dashboard needs Breadcrumb
Do we need breadcrumbs here? The dashboard is really the top-level "home" page after all. Steve Beaver
12:10 PM Bug #5475: Gateways Dashboard widget should dynamically update
Applied in changeset pfsense:commit:626db846052d79c8c154cc6f97f0ad4171bf1e13. Steve Beaver
12:08 PM Bug #5475 (Feedback): Gateways Dashboard widget should dynamically update
Fixed.
I will make the timer configurable and do the same to the IPSec widget shortly.
Steve Beaver
11:26 AM Bug #5475 (Confirmed): Gateways Dashboard widget should dynamically update
Yes, this is definitely a regression, the widget updated dynamically before. Jim Pingle
10:45 AM Bug #5475: Gateways Dashboard widget should dynamically update
The Gateways widget in 2.2.5 refreshes the RTT, Loss and Status every 10 seconds. Is that what the OP means by "dynam... Phillip Davis
09:08 PM Bug #5475 (Resolved): Gateways Dashboard widget should dynamically update
Doug Dimick
03:12 AM Bug #5459 (Confirmed): system_advanced_sysctl.php lacking input validation, output sanitation
The XSS is fixed, thanks! It's a bit overzealous on the htmlentities somewhere it appears. For instance, save the
<...
Chris Buechler
02:27 AM Bug #5460 (Not a Bug): firewall_rules_edit.php masks not updating for IPv6
True, didn't think about that, just replicated as described on the forum. This is fine, it updates correctly after ty... Chris Buechler
02:23 AM Bug #5410 (Resolved): status_graph.php rate output blank most of the time
fixed Chris Buechler

11/17/2015

05:12 PM Bug #5470 (Resolved): Dashboard needs Breadcrumb
The Status: Dashboard page doesn't have a breadcrumb at the top. Jared Dillard
01:30 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
* cries *
> The engines cannae take it, cap'n! <<
Stilez y
11:51 AM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
ya run Windows, you get to evaluate IE bugs. Jim Thompson
01:18 PM Bug #5465 (Resolved): vpn_ipsec.php - IPsec Phase 1 and Phase 2 relocation anchor icon should be moved over by the checkbox on the left
Much better there, thanks! Jim Pingle
11:00 AM Bug #5465: vpn_ipsec.php - IPsec Phase 1 and Phase 2 relocation anchor icon should be moved over by the checkbox on the left
Applied in changeset pfsense:commit:7abe8b3ed149bafa82e2803686898943065019ee. Steve Beaver
10:50 AM Bug #5465 (Feedback): vpn_ipsec.php - IPsec Phase 1 and Phase 2 relocation anchor icon should be moved over by the checkbox on the left
Moved as requested. Steve Beaver
10:13 AM Bug #5465 (Resolved): vpn_ipsec.php - IPsec Phase 1 and Phase 2 relocation anchor icon should be moved over by the checkbox on the left
Seems to make more sense to have the movement/relocation controls grouped on the left, and at least for me, the ancho... Jim Pingle
12:27 PM Bug #5467 (Resolved): firewall_nat.php - Linked firewall rule icon tooltip is missing the ID
Looks good now Jim Pingle
12:00 PM Bug #5467: firewall_nat.php - Linked firewall rule icon tooltip is missing the ID
Applied in changeset pfsense:commit:a088bcb5537b0680fba619da6bd96652ac08c0c2. Steve Beaver
11:59 AM Bug #5467 (Feedback): firewall_nat.php - Linked firewall rule icon tooltip is missing the ID
Looks like this predates pfSense 2.0 Variable used to print ID was not defined. Now set to $natent['associated-rule-id'] Steve Beaver
11:26 AM Bug #5467 (Resolved): firewall_nat.php - Linked firewall rule icon tooltip is missing the ID
When you create a port forward with a linked rule, it gets an icon to indicate that fact. When hovering the mouse poi... Jim Pingle
11:20 AM Bug #5463: Cannot mark notices as read.
Applied in changeset pfsense:commit:329a1cd58f698c3d0b62da74e52e566b4883b39c. Steve Beaver
11:14 AM Bug #5463 (Feedback): Cannot mark notices as read.
Steve Beaver
10:56 AM Bug #5463 (Assigned): Cannot mark notices as read.
Ready to test Steve Beaver
10:41 AM Bug #5463 (Feedback): Cannot mark notices as read.
I have just pushed a simplified version of the header. It does the same thing but using a different mechanism. Would ... Steve Beaver
09:40 AM Bug #5463: Cannot mark notices as read.
I do most testing with FireFox (currently 43.0b3) and cannot reproduce. I'll experiment with different system and see... Steve Beaver
09:06 AM Bug #5463: Cannot mark notices as read.
Firefox 38.4.0ESR on Windows 10 has the problem.
Google Chrome Version 46.0.2490.86 m works.
So whatever the issu...
Phillip Davis
08:27 AM Bug #5463: Cannot mark notices as read.
Tested against 32bit Nano and 64bit VM. Same result.
Steve Wheeler
08:07 AM Bug #5463: Cannot mark notices as read.
Still fails with a blank FF profile. Testing against a NanoBSD box, might be a difference there. Chromium works though. Jim Pingle
08:00 AM Bug #5463: Cannot mark notices as read.
Also fails for me in FF 42 on Mint+Cinnamon, Windows 10, and OS X 10.11.1. The FF install on OS X has no add-ons or e... Jim Pingle
07:18 AM Bug #5463: Cannot mark notices as read.
Confirmed. Some setting in FF 42 on Mint is preventing this though I can't find it.
FF 40 on GhpostBSD seems to have...
Steve Wheeler
06:59 AM Bug #5463: Cannot mark notices as read.
Yes, looks like my failure to test with more than one browser!
Doesn't work in Firefox under Linux Mint. Cleared fin...
Steve Wheeler
06:35 AM Bug #5463: Cannot mark notices as read.
Unable to reproduce.
Which browser/OS did you observe the problem with?
Steve Beaver
06:15 AM Bug #5463: Cannot mark notices as read.
It is working OK for me. I go to Diagnostics->Command Prompt and execute some PHP like:
file_notice("xyz","stuff")...
Phillip Davis
05:42 AM Bug #5463 (Resolved): Cannot mark notices as read.
Generate some notices such that they appear on the right hand side on the top bar in GUI, by generating SSH keys for ... Steve Wheeler
06:40 AM Bug #5462 (Feedback): In diag_routes.php the top section is incorrectly labelled Traceroute
Applied in changeset pfsense:commit:e897f3043f2e2fcba0916d42e29c0129dcbeb25c. Phillip Davis
06:33 AM Bug #5462: In diag_routes.php the top section is incorrectly labelled Traceroute
Corrected by PR 2073 Steve Beaver
06:01 AM Bug #5462: In diag_routes.php the top section is incorrectly labelled Traceroute
Pull request https://github.com/pfsense/pfsense/pull/2073
I also found another mislabeled one in Packet Capture http...
Phillip Davis
05:15 AM Bug #5462 (Resolved): In diag_routes.php the top section is incorrectly labelled Traceroute
Subject says it all really but that section really has nothing to do with Traceroute.
It's not labelled at all in th...
Steve Wheeler
12:06 AM Feature #5458 (Resolved): Interface statistics widget needs to update dynamically
Good enough (for now)
Thanks
Jim Thompson
07:23 PM Bug #5460 (Feedback): firewall_rules_edit.php masks not updating for IPv6
Testing this tonight I found that once I enter an IPv6 address in the network, the full range (1 -> 127) becomes avai... Steve Beaver
06:57 PM Bug #5460 (Not a Bug): firewall_rules_edit.php masks not updating for IPv6
Add a new firewall rule, change protocol to IPv6, change source or dest to "Network", and you only have 1-32 for the ... Chris Buechler

11/16/2015

02:09 PM Bug #5440 (Resolved): system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
Seems to DTRT now. Jim Pingle
01:01 PM Bug #5459 (Feedback): system_advanced_sysctl.php lacking input validation, output sanitation
Inputs validated
Error messages provided
htmlspecialchars() protection added where required
Steve Beaver
01:01 PM Bug #5459 (Resolved): system_advanced_sysctl.php lacking input validation, output sanitation
system_advanced_sysctl.php has no input validation (in 2.2.x either). We should be safe to limit Tunable and Value fi... Steve Beaver
10:23 AM Feature #5458 (Feedback): Interface statistics widget needs to update dynamically
Now pdates dynamically every 5 seconds. Steve Beaver
07:47 AM Feature #5458 (Resolved): Interface statistics widget needs to update dynamically
Steve Beaver

11/15/2015

08:27 AM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
In my defence - usually I'm on firefox! ;-) Stilez y
08:27 AM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
this was IE 11 on Win 8.1, fresh install. I'll check for issues (microsoft's compatibility mode being on/off in parti... Stilez y
11:33 PM Bug #5450 (Feedback): GUI issues in IE on DNS Resolver and Forwarder
haven't seen that anywhere either.
Stilez: what browser and OS are you running?
Chris Buechler
06:45 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
I don't see these issues either. I have tried FireFox, Safari and Chrome on the desktop, plus Safari and Firefox on O... Steve Beaver
05:43 AM Bug #5440: system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
and a suggested improvement to the diag_authentication.php for 2.3 https://github.com/pfsense/pfsense/pull/2066 Phillip Davis
05:29 AM Bug #5440: system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
I added PR https://github.com/pfsense/pfsense/pull/2065 to backport the diag_authentication.php bit of this to RELENG... Phillip Davis
04:34 AM Bug #5440: system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
In system_usermanager_settings.php in 2.2.5 it works OK for me, and looking at the code it does indeed select Local D... Phillip Davis
11:34 PM Bug #5443 (Resolved): Package LADVD display wrong text in gui.
fixed, thanks Chris Buechler

11/14/2015

05:20 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
what browser is this?
can not replicate this using firefox or chromium.
jeroen van breedam
03:05 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
Ditto "access lists" tab (see 2nd screenshot) Stilez y
03:02 PM Bug #5450 (Resolved): GUI issues in IE on DNS Resolver and Forwarder
See attached screenshot:
1) custom options scrollbar has up and down buttons but no moving viewport locator, so yo...
Stilez y
01:36 PM Bug #5443 (Closed): Package LADVD display wrong text in gui.
Looks good. Fixed. Jeremy Porter
07:20 AM Bug #5443: Package LADVD display wrong text in gui.
Applied in changeset pfsense:commit:86c772239b30e11241d11e7804da765e99ccba0b. Steve Beaver
07:14 AM Bug #5443 (Feedback): Package LADVD display wrong text in gui.
Error rectified in checkbox generation func. Steve Beaver
02:59 AM Bug #5443: Package LADVD display wrong text in gui.
Chris Buechler wrote:
> a slew of instances of that "Show log entries" message in pkg_edit.php that looks like a wro...
Kill Bill
12:36 AM Bug #5443: Package LADVD display wrong text in gui.
a slew of instances of that "Show log entries" message in pkg_edit.php that looks like a wrong copy/paste. Chris Buechler
12:32 AM Bug #5443 (Confirmed): Package LADVD display wrong text in gui.
Chris Buechler
12:32 AM Bug #5443: Package LADVD display wrong text in gui.
The screenshot Steve posted is from 2.2.x, where it's correct. Attached is from 2.3, where it's getting "Show log ent... Chris Buechler
11:59 PM Bug #5443: Package LADVD display wrong text in gui.
I have hard time understanding what "incorrect text" is shown where, even with the screenshot. Kill Bill
09:10 PM Bug #5443: Package LADVD display wrong text in gui.
After installing the LADVD package, its webpage (Services->LADVD) displays incorrect text.
The page is generated by ...
Steve Beaver
07:36 AM Bug #5440 (Feedback): system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
PR 2063 applied
The error seems to go back to at least pfSense 2.0 so please test carefully.
Steve Beaver
04:59 AM Bug #5440: system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
this might to work: https://github.com/pfsense/pfsense/pull/2063
on a related note:...
jeroen van breedam

11/13/2015

01:34 PM Bug #5443: Package LADVD display wrong text in gui.
screenshots would be nice. Jim Thompson
01:32 PM Bug #5443 (Resolved): Package LADVD display wrong text in gui.
The second bit of text is correct, but the description appears wrong. This might impact multiple packages:
Enable L...
Jeremy Porter
12:39 PM Bug #5440 (Resolved): system_usermanager_settings.php - When no Auth Server is defined, it should default to Local Database
On system_usermanager_settings.php when there is no Auth Server defined in config.xml, the drop-down for Authenticati... Jim Pingle
11:57 AM Bug #5433 (Resolved): diag_logs.php - Line wrapping issues with long unbroken lines
Looks good here now, wrapping is happening only where it should and there is no more horizontal scroll, thanks! Jim Pingle
09:42 AM Bug #5433 (Feedback): diag_logs.php - Line wrapping issues with long unbroken lines
Addressed in PR #2062 now merged. Steve Beaver
01:47 AM Bug #5433: diag_logs.php - Line wrapping issues with long unbroken lines
please check https://github.com/pfsense/pfsense/pull/2062
this works on my home setup, tested on chrome&firefox; n...
jeroen van breedam
06:19 PM Bug #5433: diag_logs.php - Line wrapping issues with long unbroken lines
One solution is to add word break opportunity tags every few character to allow the strings to break even though ther... Steve Beaver
06:15 PM Bug #5433 (Assigned): diag_logs.php - Line wrapping issues with long unbroken lines
The time column is good, still have a wrapping issue with long unbroken lines like these:... Jim Pingle
09:35 AM Todo #5439 (Feedback): Revise installed package widget and page
Completed as described Steve Beaver
08:59 AM Todo #5439 (Resolved): Revise installed package widget and page
Need to accommodate packages that are configured but not fully installed
Change icons to font awesome
Add actions t...
Steve Beaver
06:17 PM Bug #5436 (Resolved): interfaces_groups_edit.php - Group members incorrectly stored as "Array, Array" when saving
Seems to work fine here now, thanks! Jim Pingle
06:16 PM Bug #5435 (Resolved): interfaces_assign.php - "I/F" on page buttons is unnecessary
Looks better, thanks! Jim Pingle

11/12/2015

04:36 PM Bug #5433: diag_logs.php - Line wrapping issues with long unbroken lines
there's still the issue of the horizontal scrollbar.
i came across a PR for releng2_2 that had this solution for i...
jeroen van breedam
04:00 PM Bug #5433: diag_logs.php - Line wrapping issues with long unbroken lines
Applied in changeset pfsense:commit:67bfaf25c99526f5934085b680f96a6aaac71737. Steve Beaver
03:56 PM Bug #5433 (Feedback): diag_logs.php - Line wrapping issues with long unbroken lines
Fixed as requested. Steve Beaver
11:32 AM Bug #5433 (Resolved): diag_logs.php - Line wrapping issues with long unbroken lines
Looks like if there is a log line long enough it causes the timestamp column to wrap, too, which negatively impacts t... Jim Pingle
03:45 PM Bug #5435 (Feedback): interfaces_assign.php - "I/F" on page buttons is unnecessary
Gone! Steve Beaver
01:56 PM Bug #5435 (Resolved): interfaces_assign.php - "I/F" on page buttons is unnecessary
The action buttons to Add and Delete on interfaces_assign.php all have "I/F" after them, and it doesn't appear to be ... Jim Pingle
03:45 PM Bug #5436 (Feedback): interfaces_groups_edit.php - Group members incorrectly stored as "Array, Array" when saving
Fixed as described Steve Beaver
02:00 PM Bug #5436 (Resolved): interfaces_groups_edit.php - Group members incorrectly stored as "Array, Array" when saving
When adding or editing an interface group on interfaces_groups_edit.php the group members are incorrectly stored as "... Jim Pingle
11:33 AM Bug #5400 (Resolved): diag_ping.php - Following link to pre-fill page results in an incorrect error
Looks good here, it's behaving as expected now. No errors on load and it does not take action until the form is submi... Jim Pingle
11:32 AM Feature #5422 (Resolved): Provide "Add to top" buttons where required
Looks good Jim Pingle
10:33 AM Bug #5432 (Resolved): Dashboard widget config breaks on upgrade
Migration script added to /etc/inc/upgrade_config.inc Steve Beaver
10:31 AM Bug #5432 (Resolved): Dashboard widget config breaks on upgrade
The widget config on 2.3 differs from previous config formats.
An upgrade script is required to migrate it on upgr...
Steve Beaver
11:51 PM Bug #5411 (Resolved): Lost source negation on firewall_nat_edit.php
works Chris Buechler
09:40 PM Bug #5347 (Resolved): firewall_nat_out_edit.php issues
fixed Chris Buechler

11/11/2015

03:44 PM Feature #5422 (Feedback): Provide "Add to top" buttons where required
Completed and tested. Steve Beaver
03:31 PM Feature #5422 (Resolved): Provide "Add to top" buttons where required
firewall_nat.php
firewall_nat_out.php
Steve Beaver
03:28 PM Bug #5419 (Resolved): firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
Seems to work now. Saves the intended order and doesn't remove other rules. Jim Pingle
03:27 PM Bug #5419 (Feedback): firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
Removed debugging and tested. Steve Beaver
03:16 PM Bug #5419 (Assigned): firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
It doesn't erase other rules now but it also appears to have no effect. Clicking Save reverts the rules to their orde... Jim Pingle
01:48 PM Bug #5419 (Feedback): firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
Fixed by changing rule filter method. Steve Beaver
01:33 PM Bug #5419: firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
Updating the title/descr to reflect that it happens on any interface. Jim Pingle
12:12 PM Bug #5419 (Resolved): firewall_rules.php - Drag and drop of floating rules erases all rules on other interfaces
Drag and drop to reorder rules on the Floating tab of firewall_rules.php will blow away rules for all other interface... Jim Pingle
01:01 PM Bug #5418 (Resolved): firewall_rules.php - Schedule value of "none" uses a value of 0 rather than blank
Looks good now, schedule goes back to empty/blank on save if it was 0, and a new rule doesn't show a schedule (as exp... Jim Pingle
01:00 PM Bug #5418: firewall_rules.php - Schedule value of "none" uses a value of 0 rather than blank
Applied in changeset pfsense:commit:9d713b38d11242b93b41831297a8084c66e6803b. Steve Beaver
12:49 PM Bug #5418 (Feedback): firewall_rules.php - Schedule value of "none" uses a value of 0 rather than blank
Fixed as described. Steve Beaver
12:08 PM Bug #5418 (Resolved): firewall_rules.php - Schedule value of "none" uses a value of 0 rather than blank
firewall_rules.php - Schedule value of "none" uses a value of 0 rather than blank, so rules show a schedule of "0" on... Jim Pingle
12:00 PM Bug #5411: Lost source negation on firewall_nat_edit.php
Applied in changeset pfsense:commit:0dbf9cbe3fe176427350efb615504115a2b6b9bb. Phillip Davis
06:50 AM Bug #5411: Lost source negation on firewall_nat_edit.php
Applied in changeset pfsense:commit:9a3b6f7fdda6057d3f3614223c0bb42ecd38be7a. Phillip Davis
06:39 AM Bug #5411 (Feedback): Lost source negation on firewall_nat_edit.php
Fixed y Phil Davis PR 5058 Steve Beaver
06:29 AM Bug #5411: Lost source negation on firewall_nat_edit.php
Pull request https://github.com/pfsense/pfsense/pull/2058
I made the "not" checkboxes have the label "Invert match" ...
Phillip Davis
06:05 AM Bug #5411: Lost source negation on firewall_nat_edit.php
Source "not" is there on 2.2.5 - Firewall->NAT Port Forward, Edit an entry. Click the "Advanced" button to show the S... Phillip Davis
04:20 AM Bug #5411: Lost source negation on firewall_nat_edit.php
i cannot find the "not" option for source in 2.2.5 or 2.1.4
jeroen van breedam
11:00 PM Bug #5411 (Resolved): Lost source negation on firewall_nat_edit.php
The "not" option for source on firewall_nat_edit.php no longer exists.
Chris Buechler
09:20 AM Bug #5400 (Feedback): diag_ping.php - Following link to pre-fill page results in an incorrect error
Applied in changeset pfsense:commit:ed69a49666fa5f7e9fe1366d9f176ffba15536f1. Jim Pingle
09:08 AM Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect error
I'll take this, looks like there is a similar problem with traceroute, I've got a fix. Jim Pingle
08:55 AM Bug #5400 (Confirmed): diag_ping.php - Following link to pre-fill page results in an incorrect error
This shouldn't be taking the action on following the link, it should only be pre-filling the form. Automatically taki... Jim Pingle
08:53 AM Bug #5392 (Resolved): status_rrd_graph.php - RRD graph tab "VPN" not showing when it should be active
VPN option is there on all tabs now when an RA OpenVPN is present, and it not there when there is no RA VPN. Working ... Jim Pingle
07:52 AM Bug #5388 (Resolved): system_groupmanager_addprivs.php - Selection box should be much larger
Much better now, thanks! Jim Pingle
07:25 AM Bug #5388 (Feedback): system_groupmanager_addprivs.php - Selection box should be much larger
Merged Steve Beaver
06:36 PM Bug #5388: system_groupmanager_addprivs.php - Selection box should be much larger
would this be ok?
https://github.com/pfsense/pfsense/pull/2056
jeroen van breedam
07:45 AM Bug #5389 (Resolved): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Removing individual privileges for users and groups works fine with that as far as I can see. Thanks!
Jim Pingle
07:29 AM Bug #5228 (Resolved): Empty space before (drop-down) field display value
Steve Beaver
07:28 AM Todo #5356 (Resolved): Refactor row toggle code in pages that use drag/drop sorting
Steve Beaver
07:27 AM Bug #5365 (Resolved): diag_logs_filter_dynamic.php not so dynamic
Steve Beaver
07:26 AM Bug #5385 (Resolved): guiconfig.inc display_top_tabs() breaks on long tab names
Steve Beaver
07:00 AM Bug #5412: Missing alias autocomplete on firewall_nat_edit.php source field
Applied in changeset pfsense:commit:3b05e7d9fbff571d3df0d95d134acf20b64fb335. Steve Beaver
06:57 AM Bug #5412 (Feedback): Missing alias autocomplete on firewall_nat_edit.php source field
Corrected a typo in the autocomplete spec Steve Beaver
11:01 PM Bug #5412 (Resolved): Missing alias autocomplete on firewall_nat_edit.php source field
The Source field on firewall_nat_edit.php doesn't autocomplete aliases. Chris Buechler
06:40 AM Bug #5410 (Feedback): status_graph.php rate output blank most of the time
Function timer stepping on itself.
Fixed by Heper PR 2057
Steve Beaver
04:58 AM Bug #5410: status_graph.php rate output blank most of the time

https://github.com/pfsense/pfsense/pull/2057
jeroen van breedam
10:27 PM Bug #5410 (Resolved): status_graph.php rate output blank most of the time
The output of 'rate' to the right of the SVG graph on status_graph.php shows nothing most of the time. It does work t... Chris Buechler
12:21 AM Bug #5382 (Resolved): diag_ping.php source address selection not retained
fixed Chris Buechler
11:06 PM Bug #5381 (Resolved): syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
Not sure how that never generated a crash report before. Works, thanks! Chris Buechler

11/10/2015

05:51 PM Bug #5389 (Feedback): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Merged and pushed. Steve Beaver
05:42 PM Bug #5389: system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
its appears to be still 'open' on github jeroen van breedam
10:08 AM Bug #5389 (Assigned): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Is that merged? This still isn't working Jim Pingle
09:19 AM Bug #5389 (Feedback): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Fixed by PR 2047 Steve Beaver
05:43 PM Bug #5392 (Feedback): status_rrd_graph.php - RRD graph tab "VPN" not showing when it should be active
Steve Beaver
05:39 PM Bug #5392: status_rrd_graph.php - RRD graph tab "VPN" not showing when it should be active
should be ok for now, but needs a closer look. theres a work-around in one of my earlier commits:
https://github.c...
jeroen van breedam
05:40 PM Bug #5400 (Feedback): diag_ping.php - Following link to pre-fill page results in an incorrect error
Fixed by heper:patch-2 PR: 1932 now merged. Steve Beaver
05:31 PM Bug #5400: diag_ping.php - Following link to pre-fill page results in an incorrect error
proposed fix:
https://github.com/pfsense/pfsense/pull/2055
jeroen van breedam
02:54 PM Bug #5405 (Resolved): Many pages - sorting missing
That one works now, too, thanks! Jim Pingle
02:50 PM Bug #5405: Many pages - sorting missing
Applied in changeset pfsense:commit:3eeb82dc97a29353c00f359de01604eb6558670e. Steve Beaver
02:48 PM Bug #5405 (Feedback): Many pages - sorting missing
status_lb_vs.php was missing thead/tbody tags. Now sorts correctly. Steve Beaver
02:33 PM Bug #5405 (Assigned): Many pages - sorting missing
All fixed but one now:
status_lb_vs.php - Column headers appear to be clickable but no sorting happens
I've got...
Jim Pingle
02:10 PM Bug #5405: Many pages - sorting missing
Applied in changeset pfsense:commit:2f4e37b1196be724d00746eab5a1ff5ba6d27b00. Steve Beaver
02:04 PM Bug #5405 (Feedback): Many pages - sorting missing
Interestingly this sorting library only works correctly if the table is perfectly formatted with all of the proper ta... Steve Beaver
11:37 AM Bug #5405: Many pages - sorting missing
All static tables are working correctly, but tables that are populated dynamically via Javascript are not. Investigat... Steve Beaver
10:42 AM Bug #5405 (Assigned): Many pages - sorting missing
Most of them appear to be working OK, but a few issues yet:
diag_routes.php - Column headers appear to be clickabl...
Jim Pingle
08:11 AM Bug #5405 (Feedback): Many pages - sorting missing
All three tickets completed.
Note that we still need to add IP address sorting (which is now alphanumeric). Making...
Steve Beaver
02:34 PM Bug #5402 (Resolved): diag_packet_capture.php - Output display scrolling issues
Looks much better now, thanks! Jim Pingle
02:20 PM Bug #5402: diag_packet_capture.php - Output display scrolling issues
Applied in changeset pfsense:commit:58a6b59a04fa41a9d89f921b6c0c5f11e3b58691. Steve Beaver
02:13 PM Bug #5402 (Feedback): diag_packet_capture.php - Output display scrolling issues
Fonts updated as suggested Steve Beaver
12:25 PM Bug #5402: diag_packet_capture.php - Output display scrolling issues
Also there is a stray "</font>" at the end of the capture output. Jim Pingle
11:14 AM Bug #5402 (Assigned): diag_packet_capture.php - Output display scrolling issues
No consolas here on Linux, maybe something like:
consolas,monaco,roboto mono,liberation mono,courier
Seems to w...
Jim Pingle
11:00 AM Bug #5402: diag_packet_capture.php - Output display scrolling issues
Applied in changeset pfsense:commit:3963c87953671c9e608c48ce9a263de33e788ddc. Steve Beaver
10:50 AM Bug #5402: diag_packet_capture.php - Output display scrolling issues
Applied in changeset pfsense:commit:0e4b8bf75fc1fb8a42dca4ae824ffd5de2fdccc2. Steve Beaver
10:49 AM Bug #5402 (Feedback): diag_packet_capture.php - Output display scrolling issues
Font changed to consolas Steve Beaver
09:24 AM Bug #5402 (Assigned): diag_packet_capture.php - Output display scrolling issues
Scrolling is much better, thanks!
One last nit: It should be in a fixed-width font
Jim Pingle
09:10 AM Bug #5402: diag_packet_capture.php - Output display scrolling issues
Applied in changeset pfsense:commit:756dc38e635243b2cb0fb38a1de888085344d408. Steve Beaver
09:07 AM Bug #5402 (Feedback): diag_packet_capture.php - Output display scrolling issues
Fixed as requested. Steve Beaver
10:31 AM Bug #5393 (Resolved): vpn_ipsec.php - No way to save re-ordered Phase 2 entries
Looks OK the way it is after that commit Jim Pingle
10:30 AM Bug #5393: vpn_ipsec.php - No way to save re-ordered Phase 2 entries
Applied in changeset pfsense:commit:f34b7665264fd4e3e05c11fe87fbd68174030624. Steve Beaver
10:26 AM Bug #5393 (Feedback): vpn_ipsec.php - No way to save re-ordered Phase 2 entries
Fixed by reverting to "Move to here" control/icon
Bootstrap does not support dragging nested tables, so until this...
Steve Beaver
09:15 AM Bug #5399 (Resolved): status_dhcp_leases.php - Output not sortable
Works, thanks! Jim Pingle
08:12 AM Bug #5399: status_dhcp_leases.php - Output not sortable
Completed Steve Beaver
06:57 AM Bug #5399: status_dhcp_leases.php - Output not sortable
Looks like all of them should be sortable Jim Pingle
06:29 AM Bug #5399 (Feedback): status_dhcp_leases.php - Output not sortable
Looks like there are three tables on this page:
Pool status
Leases
Leases in use
Which should be sortable?
Steve Beaver
09:15 AM Bug #5398 (Resolved): diag_arp.php - Output is not sortable
Works, thanks! Jim Pingle
08:11 AM Bug #5398 (Feedback): diag_arp.php - Output is not sortable
Steve Beaver

11/09/2015

02:54 PM Bug #5395 (Resolved): diag_logs.php - Reading log text is difficult (Lack of line wrapping, bg color)
That is much easier on the eyes, thanks! Jim Pingle
02:50 PM Bug #5395: diag_logs.php - Reading log text is difficult (Lack of line wrapping, bg color)
Applied in changeset pfsense:commit:ba6c5357c5c9fd342678f8bad20066f1f56c31cd. Steve Beaver
02:42 PM Bug #5395 (Feedback): diag_logs.php - Reading log text is difficult (Lack of line wrapping, bg color)
Log viewer changed to table layout to support wrapping. Steve Beaver
12:24 PM Bug #5395 (Resolved): diag_logs.php - Reading log text is difficult (Lack of line wrapping, bg color)
The lack of wrapping on content displayed by diag_logs.php aligns better but it makes it really difficult to read lon... Jim Pingle
02:32 PM Bug #5404 (Resolved): diag_sockets.php - Info dump at the bottom of the screen could be wrapped in an info box
Looks much cleaner now, thanks! Jim Pingle
02:20 PM Bug #5404: diag_sockets.php - Info dump at the bottom of the screen could be wrapped in an info box
Applied in changeset pfsense:commit:b9a5448f314e05e808f8847fd2845d403a79bfe5. Steve Beaver
02:15 PM Bug #5404 (Feedback): diag_sockets.php - Info dump at the bottom of the screen could be wrapped in an info box
Fixed as described.
This page had a number of other shortcomings. I think it was the first page I ever converted :)
Steve Beaver
01:03 PM Bug #5404 (Resolved): diag_sockets.php - Info dump at the bottom of the screen could be wrapped in an info box
There's a link at the top of diag_sockets.php and then a big block of info at the bottom that seems like it could be ... Jim Pingle
02:31 PM Bug #5403 (Resolved): diag_smart.php - Action buttons look funny outside of the groups
Much better, thanks! Jim Pingle
02:30 PM Bug #5403: diag_smart.php - Action buttons look funny outside of the groups
Applied in changeset pfsense:commit:d254b99e18e5a4924510c26f7dbcba90aea1e53e. Steve Beaver
02:26 PM Bug #5403 (Feedback): diag_smart.php - Action buttons look funny outside of the groups
Fixed Steve Beaver
01:02 PM Bug #5403 (Resolved): diag_smart.php - Action buttons look funny outside of the groups
Not sure if there is a way to group the buttons with their options here, if not just close this. It seems like it wou... Jim Pingle
02:13 PM Bug #5388: system_groupmanager_addprivs.php - Selection box should be much larger
Forgot to reassign this one. Jim Pingle
01:26 PM Bug #5388: system_groupmanager_addprivs.php - Selection box should be much larger
Pic for reference:
!http://i.imgur.com/YULqzlo.png!
Jim Pingle
01:25 PM Bug #5388 (Assigned): system_groupmanager_addprivs.php - Selection box should be much larger
Looks like the size of the group membership boxes was increased, those were fine before, what needs sized up is the p... Jim Pingle
12:50 PM Bug #5388: system_groupmanager_addprivs.php - Selection box should be much larger
Applied in changeset pfsense:commit:9c45111c9278a6c7f2a0b017e57ab93edee8dfb3. Steve Beaver
12:24 PM Bug #5388 (Feedback): system_groupmanager_addprivs.php - Selection box should be much larger
Multiselect boxes enlarged Steve Beaver
10:06 AM Bug #5388 (Resolved): system_groupmanager_addprivs.php - Selection box should be much larger
On system_groupmanager_addprivs.php the list is huge but the selection box is tiny.
The same control on system_use...
Jim Pingle
02:00 PM Bug #5391 (Resolved): services_snmp.php - "Host Resources" requires mibII, JS/Input Validation missing
Behavior works as expected now, thanks! Jim Pingle
01:30 PM Bug #5391: services_snmp.php - "Host Resources" requires mibII, JS/Input Validation missing
Applied in changeset pfsense:commit:e49bf8fdce7438d7685c0106c654ecf2afbbde49. Steve Beaver
01:25 PM Bug #5391 (Feedback): services_snmp.php - "Host Resources" requires mibII, JS/Input Validation missing
Corrected. Steve Beaver
11:56 AM Bug #5391 (Resolved): services_snmp.php - "Host Resources" requires mibII, JS/Input Validation missing
On services_snmp.php when checking Host Resources, the mibII checkbox should also be automatically checked and it sho... Jim Pingle
01:34 PM Bug #5389: system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
only a partial fix
https://github.com/pfsense/pfsense/pull/2047
jeroen van breedam
10:07 AM Bug #5389 (Resolved): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
On system_groupmanager.php & system_usermanager.php assigned privileges have no "delete" icon. Once a privilege is ad... Jim Pingle
01:29 PM Bug #5401 (Resolved): diag_packet_capture.php - "Level of detail" option has an extra entry for "Any"
Spurious option is gone, all OK now. Thanks! Jim Pingle
01:10 PM Bug #5401: diag_packet_capture.php - "Level of detail" option has an extra entry for "Any"
Applied in changeset pfsense:commit:b46dc238c6a3fe595c92882493879c0ae0df253b. Steve Beaver
01:02 PM Bug #5401 (Feedback): diag_packet_capture.php - "Level of detail" option has an extra entry for "Any"
Fixed Steve Beaver
12:55 PM Bug #5401 (Resolved): diag_packet_capture.php - "Level of detail" option has an extra entry for "Any"
On diag_packet_capture.php the "Level of detail" control has an extra entry for "Any" that shouldn't be there. It sho... Jim Pingle
01:28 PM Bug #5397 (Resolved): firewall_aliases.php - Weird change in line thickness
Looks consistent now, thanks! Jim Pingle
12:50 PM Bug #5397: firewall_aliases.php - Weird change in line thickness
Applied in changeset pfsense:commit:af5e730bad27b8ca99c7a21d3b1afc2176bba0d9. Steve Beaver
12:44 PM Bug #5397 (Feedback): firewall_aliases.php - Weird change in line thickness
Corrected Steve Beaver
12:34 PM Bug #5397 (Resolved): firewall_aliases.php - Weird change in line thickness
So nitpicky I almost didn't open a ticket. Saw this on a couple pages but the only one I could remember was Aliases. ... Jim Pingle
01:28 PM Bug #5396 (Resolved): diag_logs_filter.php - Minor display issues/fixes
Striping looks better, thanks! Jim Pingle
12:50 PM Bug #5396: diag_logs_filter.php - Minor display issues/fixes
Applied in changeset pfsense:commit:0be23c99ec3811bbee62ebda49521fc0b1a4b594. Steve Beaver
12:36 PM Bug #5396 (Feedback): diag_logs_filter.php - Minor display issues/fixes
Table striped.
I will center the icon in a later revision when I revise the CSS
Steve Beaver
12:30 PM Bug #5396 (Resolved): diag_logs_filter.php - Minor display issues/fixes
* Looks like the Act icon could be centered in its column, it looks like it's too far to the left now. Not a huge dea... Jim Pingle
01:27 PM Bug #5394 (Resolved): diag_logs.php - blank line at the top of log display
Looks good! Jim Pingle
12:50 PM Bug #5394: diag_logs.php - blank line at the top of log display
Applied in changeset pfsense:commit:d1a5ed338b92f1bbb9ec5d70db1de624854d17e2. Steve Beaver
12:25 PM Bug #5394 (Feedback): diag_logs.php - blank line at the top of log display
Removed Steve Beaver
12:18 PM Bug #5394 (Resolved): diag_logs.php - blank line at the top of log display
On diag_logs.php there seems to be an extra blank line at the top of each log
!http://i.imgur.com/tFkJIW4.png!
Jim Pingle
01:24 PM Bug #5390 (Resolved): firewall_schedule.php - "Schedule active" icon is not rendering on Linux
Looks great now everywhere, thanks! Jim Pingle
11:56 AM Bug #5390: firewall_schedule.php - "Schedule active" icon is not rendering on Linux
Icons converted to fonts awesome. Steve Beaver
11:50 AM Bug #5390 (Feedback): firewall_schedule.php - "Schedule active" icon is not rendering on Linux
Applied in changeset pfsense:commit:b96cb0a5a258acf660a8c04156b47855121b70c4. Steve Beaver
10:20 AM Bug #5390 (Resolved): firewall_schedule.php - "Schedule active" icon is not rendering on Linux
The icon to indicate an active schedule is not rendering on Linux in Firefox (left) or Chrome (right):
!http://i.i...
Jim Pingle
01:13 PM Bug #5405 (Resolved): Many pages - sorting missing
The following pages/widgets had sortable output on 2.2.x but are not sortable on 2.3.x
carp_status.php - List of V...
Jim Pingle
12:58 PM Bug #5402 (Resolved): diag_packet_capture.php - Output display scrolling issues
The length of the output display on diag_packet_capture.php isn't being limited which can make the page grow very lar... Jim Pingle
12:52 PM Bug #5400 (Resolved): diag_ping.php - Following link to pre-fill page results in an incorrect error
If you follow a link, such as one from Diag > DNS Lookup, to diag_ping.php similar to this:
diag_ping.php?host=goo...
Jim Pingle
12:45 PM Bug #5399: status_dhcp_leases.php - Output not sortable
Also status_dhcpv6_leases.php Jim Pingle
12:45 PM Bug #5399 (Resolved): status_dhcp_leases.php - Output not sortable
The list of systems on status_dhcp_leases.php was sortable in JS on 2.2.x, and that is handy especially when tracking... Jim Pingle
12:44 PM Bug #5398 (Resolved): diag_arp.php - Output is not sortable
The list of systems on diag_arp.php was sortable in JS on 2.2.x, and that is handy especially when tracking down syst... Jim Pingle
12:08 PM Bug #5393 (Resolved): vpn_ipsec.php - No way to save re-ordered Phase 2 entries
The Phase 2 entries allow dragging/dropping but there is no Save icon inside the P2 and the state doesn't save when c... Jim Pingle
12:07 PM Bug #5392 (Resolved): status_rrd_graph.php - RRD graph tab "VPN" not showing when it should be active
The VPN tab on status_rrd_graph.php should be showing up when there is a remote access OpenVPN configured.
The tab...
Jim Pingle
07:40 AM Bug #5380: setup wizard timezone should default to GMT
Applied in changeset pfsense:commit:f8ae35862e05b1d5b43678144071a6e03ab8c3c5. Steve Beaver
07:25 AM Bug #5380: setup wizard timezone should default to GMT
The default config.xml used to contain "<timezone>"Etc/UDT"</timezone> but that was recently removed when changing fr... Steve Beaver
07:09 AM Bug #5380 (Feedback): setup wizard timezone should default to GMT
The 2.2 code seems to do the opposite! It creates a selector using the timezonelist, but removes GMT from that list.
...
Steve Beaver

11/08/2015

08:50 PM Bug #5385: guiconfig.inc display_top_tabs() breaks on long tab names
Applied in changeset pfsense:commit:02e2825a852bc0cd10cf0bc38b933a03c7da0a45. Steve Beaver
08:40 PM Bug #5385 (Feedback): guiconfig.inc display_top_tabs() breaks on long tab names
Fixed
Cherry picked from suggested code change in forum message
Steve Beaver
08:23 PM Bug #5385 (Resolved): guiconfig.inc display_top_tabs() breaks on long tab names
https://forum.pfsense.org/index.php?topic=102059.msg569234#msg569234
Steve Beaver
08:10 PM Bug #5384 (Resolved): status_nptd.php - syntax error
Bonus */ removed. File tested. Steve Beaver
08:09 PM Bug #5384 (Resolved): status_nptd.php - syntax error
https://forum.pfsense.org/index.php?topic=102064.msg0#new Steve Beaver
08:10 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
Applied in changeset pfsense:commit:57cadb042dc133f1a3a671f4ff823589760574bf. Steve Beaver
08:03 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
php corrected and wrapped in <![CDATA[ ]]> Steve Beaver
07:50 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
Sure, but it's interesting that this problem has been in there since RELENG_2.0 Steve Beaver

11/07/2015

04:18 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
And in general, all that entity crap in that file (like descriptions) would benefit from the same. Completely unreada... Kill Bill
04:13 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
Put that between CDATA. Kill Bill
01:10 PM Bug #5381 (Feedback): syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
I'm guessing this is the culprit: (line 3 of the PHP)... Steve Beaver
12:56 AM Bug #5381 (Resolved): syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3
Go through the setup wizard, set the hostname and timezone, leave rest at defaults. Go back to the dashboard at the e... Chris Buechler
01:20 PM Bug #5382: diag_ping.php source address selection not retained
Applied in changeset pfsense:commit:3f91d34e5e20d9b110e50d9f9a82a14f6ebc5ec3. Steve Beaver
01:17 PM Bug #5382 (Feedback): diag_ping.php source address selection not retained
Initial value incorrectly obtained from $pconfig. Now corrected. Steve Beaver
01:17 AM Bug #5382 (Resolved): diag_ping.php source address selection not retained
On diag_ping.php, pick a source like "LAN", fill in an IP, and ping. The page that returns with the results used to r... Chris Buechler
12:47 AM Bug #5380 (Resolved): setup wizard timezone should default to GMT
The timezone in the setup wizard defaults to the first in the list. Should default to GMT as before. Chris Buechler

11/05/2015

02:23 PM Bug #5375 (Resolved): diag_logs_filter.php Search functionality broken
Steve Beaver
11:21 AM Bug #5375: diag_logs_filter.php Search functionality broken
https://github.com/pfsense/pfsense/pull/2033 jeroen van breedam
10:06 AM Bug #5375 (Resolved): diag_logs_filter.php Search functionality broken
Installed 2.3-Alpha on my fpsense SG-2440... Used to sort firewall logs with "Block" checkmark to see whats blocked o... Steve Beaver

11/03/2015

11:06 AM Bug #5369 (Resolved): Thermal sensor widget no longer functions
Widget re-written to use correct 2.3 widget structure.
Now uses Bootstrap stacked progress bars that change color to ...
Steve Beaver
11:04 AM Bug #5369 (Resolved): Thermal sensor widget no longer functions
Widget was converted to Bootstrap at some point, but it is no longer functional since the graphing library it uses ha... Steve Beaver
09:04 PM Bug #5365: diag_logs_filter_dynamic.php not so dynamic
https://github.com/pfsense/pfsense/pull/2019
should help with the cross/tick button and getting the syntax correct f...
Phillip Davis

11/02/2015

12:51 PM Bug #5365 (Feedback): diag_logs_filter_dynamic.php not so dynamic
Dynamism has been restored.
etc/inc/filter_log.inc has been updated to use fa icon, but still needs work similar t...
Steve Beaver
11:50 AM Bug #5365 (Resolved): diag_logs_filter_dynamic.php not so dynamic
There is no "dynamic" to Firewall Log Dynamic view.
diag_logs_filter_dynamic.php refers to /javascript/filter_log.js...
Steve Beaver

10/31/2015

09:35 AM Bug #5357 (Resolved): Simplify vpn_ipsec.php
Steve Beaver

10/30/2015

02:06 PM Bug #5359 (Resolved): Update UI pages to use copyright-master
Steve Beaver
09:06 AM Feature #5358 (Resolved): Setup wizard PPPoE password field should be type password, not text
Steve Beaver
09:03 AM Feature #5358 (Resolved): Setup wizard PPPoE password field should be type password, not text
Need to protect from prying eyes.
Also requires "Show password" button to allow checking for typos.
Steve Beaver

10/29/2015

03:00 PM Bug #5228 (Feedback): Empty space before (drop-down) field display value
A combination of the suggested methods seems to produce the best display. Select padding has been reduced from 12 to ... Steve Beaver
01:48 PM Bug #5357 (Resolved): Simplify vpn_ipsec.php
This page is a mess of buttons, icons and sortable rows. It really needs to be completely re-written using a jQuery l... Steve Beaver
09:15 AM Todo #5356 (Feedback): Refactor row toggle code in pages that use drag/drop sorting
Refactor completed and tested. Steve Beaver
09:10 AM Todo #5356 (Resolved): Refactor row toggle code in pages that use drag/drop sorting
Move row toggle code to jquery/pfSenseHelpers.js to make hte pages consistent and reduce code size.
usr/local/www/...
Steve Beaver

10/28/2015

03:28 PM Bug #5228: Empty space before (drop-down) field display value
to clarify myself: google found a way to fix.....
i'm just idiot with some spare time ;)
jeroen van breedam
03:25 PM Bug #5228: Empty space before (drop-down) field display value
found a way to fix it without having to manually add classes to the option fields
https://github.com/pfsense/pfsen...
jeroen van breedam
03:07 PM Bug #5228: Empty space before (drop-down) field display value
Thanks. If we really need to do this, I think your second scheme "create a new entry in pfsense.css ".form-select-opt... Steve Beaver
02:49 PM Bug #5228: Empty space before (drop-down) field display value
<select class=form-control> form-control has padding enabled
the class is not applied to it's <option>'s
so...
jeroen van breedam
11:40 AM Bug #5352 (Resolved): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.
Steve Beaver
10:20 AM Bug #5352: interfaces_vlan_edit.php produces errors related to the "interfaces" selector.
Applied in changeset pfsense:commit:ed7f3bbcda1767494e90d779fa92a4d8fcac2524. Steve Beaver
10:17 AM Bug #5352 (Feedback): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.
Replaced complex and unsafe options generation code with a safer function. Steve Beaver
10:15 AM Bug #5352 (Resolved): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.
https://forum.pfsense.org/index.php?topic=101537.0 Steve Beaver

10/27/2015

10:47 AM Bug #5349 (Resolved): wake_on_line.widget.php - Layout needs to be improved
Widget table Bootstrap formatted.
Icons changed to more suitable font-awesome icons.
Tool-tips added.
Steve Beaver
10:09 AM Bug #5349 (Resolved): wake_on_line.widget.php - Layout needs to be improved
Current layout is unattractive and uninformative. Steve Beaver
10:01 AM Bug #5348 (Resolved): Viewing on mobile device
Steve Beaver
09:55 AM Bug #5348: Viewing on mobile device
I have just tried it and works fine now thanks Jake Rote
09:35 AM Bug #5348: Viewing on mobile device
You can git-sync now to get it. It will also be in the next image, but I'm not sure what time today that will be gene... Steve Beaver
08:48 AM Bug #5348: Viewing on mobile device
Ok cool what build will this be in? Jake Rote
07:32 AM Bug #5348: Viewing on mobile device
Great. Thank you. I will start testing in that way too.
I have added the metadata tag
Steve Beaver
07:22 AM Bug #5348: Viewing on mobile device
This happens on my note 4 it's due to the PPI but the viewport header fixes this. I managed to replicate in chrome de... Jake Rote
07:08 AM Bug #5348 (Feedback): Viewing on mobile device
Thanks Jake.
I have been testing device compatibility using Safari in "Responsive design mode" like this, and have n...
Steve Beaver
06:36 AM Bug #5348 (Resolved): Viewing on mobile device
Bootstrap is not displaying correctly on mobile as the following metadata is missing from the top of the <head> secti... Jake Rote
07:00 AM Bug #5347: firewall_nat_out_edit.php issues
Applied in changeset pfsense:commit:9fc6233a19532421c5ff8f88745d6345cb978fc5. Steve Beaver
06:52 AM Bug #5347 (Feedback): firewall_nat_out_edit.php issues
The two missing elements had been provided, but were hidden unless the protocol was set to TCP, UDP or TCP/UDP.
I ...
Steve Beaver
12:37 AM Bug #5347: firewall_nat_out_edit.php issues
thanks Phil, merged that. Chris Buechler
11:15 PM Bug #5347: firewall_nat_out_edit.php issues
Part (1) should be fixed by https://github.com/pfsense/pfsense/pull/1989
I will leave parts (2) and (3) for Mr Bea...
Phillip Davis
10:14 PM Bug #5347 (Resolved): firewall_nat_out_edit.php issues
1) The source field loses its value upon editing an existing rule.
2) the static port checkbox has gone missing
3...
Chris Buechler
01:14 AM Bug #5288: After Execute PHP Commands with bad code, menus do not work
I can understand that! I am happy to see the results of the crud code that I typed, and press "No" to not submit the ... Phillip Davis
12:46 AM Bug #5288: After Execute PHP Commands with bad code, menus do not work
Phillip Davis wrote:
>
> It still gives the "crash report" stuff, which is good
This part, I'm not sure that's ...
Chris Buechler
12:35 AM Bug #5288 (Resolved): After Execute PHP Commands with bad code, menus do not work
thanks Phil.
The general issue Steve discussed earlier today as part of this, where PHP getting stuck making the ...
Chris Buechler
11:23 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work
2.3-ALPHA (amd64)
built on Mon Oct 26 19:32:58 CDT 2015
FreeBSD 10.2-STABLE
That works nicely now. It still gi...
Phillip Davis

10/26/2015

03:10 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work
Applied in changeset pfsense:commit:3e115dbf716a9bdb6b972a367c0f0a44f183f6ab. Steve Beaver
03:09 PM Bug #5288 (Feedback): After Execute PHP Commands with bad code, menus do not work
Changed the code to write the user's PHP to a file and execute it with a new instance of PHP.
Seems to fix the pro...
Steve Beaver
02:34 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work
My testing has not uncovered an answer to this yet. Basically fatal PHP errors (as opposed to syntax errors) cause th... Steve Beaver

10/23/2015

09:16 AM Bug #5336 (Resolved): Page must be refreshed after pkg install to show new menu items
Works Jim Pingle

10/22/2015

03:50 PM Bug #5311 (Feedback): vpn_openvpn_*.php: export tabs not installed after installing openvpn client export package
Applied in changeset pfsense:commit:a2b0d90982e6d0e2b6e36cf3cf2b258628244ca3. Renato Botelho
11:30 AM Bug #5336: Page must be refreshed after pkg install to show new menu items
Applied in changeset pfsense:commit:db1cc32f5ad36be20896e5688a810065efd7e6bc. Steve Beaver
11:21 AM Bug #5336 (Feedback): Page must be refreshed after pkg install to show new menu items
Page performs a sneaky refresh after a successful install/remove. Menu changes now take effect immediately. Steve Beaver
11:18 AM Bug #5336 (Resolved): Page must be refreshed after pkg install to show new menu items
After a new package is installed new menu items may be installed. You can't see them, however, until you refresh the ... Steve Beaver
 

Also available in: Atom