Project

General

Profile

Activity

From 11/18/2015 to 12/17/2015

11/30/2015

03:22 PM Bug #5389 (Resolved): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Seems to work OK now. Jim Pingle
02:20 PM Bug #5389: system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Applied in changeset pfsense:commit:945204b1590dbd3d8eb774b961b3cfa77d1e9407. Steve Beaver
02:13 PM Bug #5389 (Feedback): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Priv table was incorrectly numbered because privs inherited from a group should not be deletable Steve Beaver
12:46 PM Bug #5389: system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
May just be the first privilege. I had issues deleting the last one but then after deleting some middle ones it worke... Jim Pingle
12:45 PM Bug #5389 (Assigned): system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges
Looks like there is one little issue here yet or perhaps it crept in after other changes. On system_usermanager.php y... Jim Pingle

11/20/2015

07:35 AM Todo #5439 (Resolved): Revise installed package widget and page
Renato Botelho
01:40 AM Bug #5459 (Resolved): system_advanced_sysctl.php lacking input validation, output sanitation
looks good, thanks! Chris Buechler
01:03 AM Bug #5482 (Resolved): Hard disk standby time missing
works, thanks! Chris Buechler
12:56 AM Todo #5478 (Resolved): Page title text duplication
looks good Chris Buechler
12:55 AM Bug #5450 (Resolved): GUI issues in IE on DNS Resolver and Forwarder
yeah that does it, looks good Chris Buechler
12:36 AM Bug #5490 (Resolved): bad validation on system_usermanager_settings.php
fixed Chris Buechler
06:50 PM Bug #5490: bad validation on system_usermanager_settings.php
Applied in changeset pfsense:commit:e6d97c6e14f21fc1160dc47a53a97328583c87ae. Steve Beaver
06:43 PM Bug #5490 (Feedback): bad validation on system_usermanager_settings.php
Numeric input limit set to zero.
The error message printed when the test is not performed was in the wrong place s...
Steve Beaver

11/19/2015

05:24 PM Bug #5490 (Resolved): bad validation on system_usermanager_settings.php
it says "Enter 0 to never expire sessions." but forces you to enter a number greater than 0.
Also "Save" and "Save...
Jared Dillard
02:53 PM Bug #5470 (Resolved): Dashboard needs Breadcrumb
Thanks Steve! Jared Dillard
07:14 AM Bug #5470: Dashboard needs Breadcrumb
Breadcrumbs provided. Steve Beaver
11:50 AM Todo #5478 (Feedback): Page title text duplication
Applied in changeset pfsense:commit:1908003a5163d8acd29cd89ab901718caca0b645. Anonymous
11:44 AM Todo #5478: Page title text duplication
I can't change the status to Feedback, but I committed CSS changes that removes the first line and make the 2nd line ... Jared Dillard
07:17 AM Todo #5478: Page title text duplication
Breadcrumbs are now generated on index.php allowing their display to be controlled by CSS.
Re-assigning to JDillard.
Steve Beaver
10:03 AM Bug #5486 (Resolved): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Works now, thanks! Jim Pingle
10:00 AM Bug #5486: firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Applied in changeset pfsense:commit:c2e566f479297257b94b5318aba6458c299d2d65. Steve Beaver
09:52 AM Bug #5486 (Feedback): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
Fixed Steve Beaver
09:35 AM Bug #5486 (Resolved): firewall_nat.php - Clicking "Save" after drag/drop reordering does nothing
On firewall_nat.php when you drag and drop to reorder rules, then click save, the order is not stored. The page refre... Jim Pingle
09:11 AM Bug #5450 (Feedback): GUI issues in IE on DNS Resolver and Forwarder
It seems that some versions of IE doesn't like tables that have an empty <tbody>. Those are now detected via jQuery a... Steve Beaver
07:38 AM Bug #5459 (Feedback): system_advanced_sysctl.php lacking input validation, output sanitation
Kinder, gentler version now saves: "'>alert("hi");" by using strip_tags rather than htmlspecialchars Steve Beaver
06:57 AM Bug #5482 (Feedback): Hard disk standby time missing
Steve Beaver
01:37 AM Bug #5482 (Resolved): Hard disk standby time missing
system_advanced_misc.php used to have the "Hard disk standby time" configuration option.
https://github.com/pfsense...
Chris Buechler
06:50 AM Bug #5463 (Resolved): Cannot mark notices as read.
Steve Beaver
06:15 AM Bug #5463: Cannot mark notices as read.
Confirmed. Working fine with this mornings update in FF42 in Mint. Steve Wheeler
05:20 AM Bug #5463: Cannot mark notices as read.
Steve Wheeler - Can you confirm please? Steve Beaver
11:10 PM Bug #5463: Cannot mark notices as read.
Also worked for me afterwards. I merged Phil's pull request to double check without the debug, and it's fine.
Wil...
Chris Buechler
10:03 PM Bug #5463: Cannot mark notices as read.
That works in Firefox 38.4.0 and Google Chrome. Both using the UI and "closenotice=all" is good.
I can take the "nor...
Phillip Davis
06:14 PM Bug #5463: Cannot mark notices as read.
Added some debbuging. You should get an alert on clicking the Clear button, and another when thee notices have been c... Steve Beaver
06:11 AM Bug #5475 (Resolved): Gateways Dashboard widget should dynamically update
Steve Beaver
11:38 PM Bug #5475: Gateways Dashboard widget should dynamically update
and I just added another commit to that PR 2086 to remove some duplicated code that had snuck into master somewhere a... Phillip Davis
09:34 PM Bug #5475: Gateways Dashboard widget should dynamically update
https://github.com/pfsense/pfsense/pull/2086
$display_type var setting needs to be earlier.
Phillip Davis
09:16 PM Bug #5475: Gateways Dashboard widget should dynamically update
I should always look for regressions also! JimP is correct - monitor IP has gone AWOL, even on first display. Phillip Davis
09:02 PM Bug #5475: Gateways Dashboard widget should dynamically update
Works for me - thanks. Phillip Davis
08:59 PM Bug #5475 (Assigned): Gateways Dashboard widget should dynamically update
Updates OK but now it doesn't display the monitor IP. Jim Pingle

11/18/2015

05:14 PM Bug #5310 (Resolved): Wizard error page not correctly formatted
fixed Chris Buechler
05:09 PM Bug #5380 (Resolved): setup wizard timezone should default to GMT
fixed Chris Buechler
04:30 PM Bug #5463: Cannot mark notices as read.
Still not working for me in FF42 on Mint. Updated to latest code and Gitsynced to Master. Steve Wheeler
03:58 PM Bug #5463: Cannot mark notices as read.
Same with Firefox 41 and 42 on Windows, including in FF safe mode. Chris Buechler
11:24 AM Bug #5463: Cannot mark notices as read.
If this continues to be a problem, I'll add some debug to help you track it down. Let's see what feedback we get from... Steve Beaver
11:23 AM Bug #5463: Cannot mark notices as read.
Works for me now in FF where it did not work before. On a current snap + gitsync though. Jim Pingle
10:51 AM Bug #5463: Cannot mark notices as read.
This still does not work for me in Firefox 38.4.0ESR.
I tried ctrl-F5 to (hopefully) reload any cached JS or...
It ...
Phillip Davis
04:14 PM Bug #5450: GUI issues in IE on DNS Resolver and Forwarder
Dug an old laptop out of the basement and was able to reproduce. Also tested a work-around that seems effective. I wi... Steve Beaver
02:57 AM Bug #5450 (Confirmed): GUI issues in IE on DNS Resolver and Forwarder
This happens on services_dnsmasq.php as well as the unbound pages described using IE with compatibility mode disabled... Chris Buechler
04:02 PM Bug #5311 (Resolved): vpn_openvpn_*.php: export tabs not installed after installing openvpn client export package
fixed Chris Buechler
03:59 PM Bug #5412 (Resolved): Missing alias autocomplete on firewall_nat_edit.php source field
fixed Chris Buechler
03:58 PM Bug #5479 (Resolved): Dashboard widget control icons no longer flush right
Noted :) I don't think this one was related to my changes, but it is fixed now regardless.
https://github.com/pfsens...
Jared Dillard
10:40 AM Bug #5479: Dashboard widget control icons no longer flush right
And related to the icons going AWOL for the last 16 hours or so - https://forum.pfsense.org/index.php?topic=102617.0
...
Phillip Davis
10:34 AM Bug #5479 (Feedback): Dashboard widget control icons no longer flush right
I think this was a JDillard experiment ? Steve Beaver
10:33 AM Bug #5479 (Resolved): Dashboard widget control icons no longer flush right
Some time in the last two days the widget icons stopped being aligned to the right upper corner:
!http://i.imgur.c...
Jim Pingle
03:45 PM Bug #5462 (Resolved): In diag_routes.php the top section is incorrectly labelled Traceroute
fixed Chris Buechler
03:15 PM Todo #5478: Page title text duplication
check out the dark theme, I hid the first line and made the breadcrumbs a larger font. This is the reason I want the ... Jared Dillard
03:04 PM Todo #5478: Page title text duplication
Is there any situation in which the page title isn't contained in the breadcrumbs? Chris Buechler
06:54 AM Todo #5478: Page title text duplication
The first line is the page title. (What this page does)
The second line contains the breadcrumbs (how we got here)
...
Steve Beaver
03:16 AM Todo #5478 (Resolved): Page title text duplication
Pages have their title displayed twice right next to each other, which is redundant and chews up screen space unneces... Chris Buechler
01:13 PM Bug #5470: Dashboard needs Breadcrumb
It is best for styling consistency, otherwise it is odd man out and you have to make special styling rules for it. Jared Dillard
01:12 PM Bug #5470 (Feedback): Dashboard needs Breadcrumb
Do we need breadcrumbs here? The dashboard is really the top-level "home" page after all. Steve Beaver
12:10 PM Bug #5475: Gateways Dashboard widget should dynamically update
Applied in changeset pfsense:commit:626db846052d79c8c154cc6f97f0ad4171bf1e13. Steve Beaver
12:08 PM Bug #5475 (Feedback): Gateways Dashboard widget should dynamically update
Fixed.
I will make the timer configurable and do the same to the IPSec widget shortly.
Steve Beaver
11:26 AM Bug #5475 (Confirmed): Gateways Dashboard widget should dynamically update
Yes, this is definitely a regression, the widget updated dynamically before. Jim Pingle
10:45 AM Bug #5475: Gateways Dashboard widget should dynamically update
The Gateways widget in 2.2.5 refreshes the RTT, Loss and Status every 10 seconds. Is that what the OP means by "dynam... Phillip Davis
03:12 AM Bug #5459 (Confirmed): system_advanced_sysctl.php lacking input validation, output sanitation
The XSS is fixed, thanks! It's a bit overzealous on the htmlentities somewhere it appears. For instance, save the
<...
Chris Buechler
02:27 AM Bug #5460 (Not a Bug): firewall_rules_edit.php masks not updating for IPv6
True, didn't think about that, just replicated as described on the forum. This is fine, it updates correctly after ty... Chris Buechler
02:23 AM Bug #5410 (Resolved): status_graph.php rate output blank most of the time
fixed Chris Buechler
 

Also available in: Atom