pfSense

Code style for pkg-utils

Merge pull request #1524 from phil-davis/Code-Style-Guide-Interfaces-inc

Merge pull request #1523 from phil-davis/patch-2

Merge pull request #1522 from phil-davis/Code-Style-Guide-etc-inc-f-to-g

Code style guide interfaces.inc

This is another big file that has many diffs so Github refuses to
display them. I thought it best to keep doing individual commit-pull for
ones like this.

More style guide changes

In gwlb.inc at line 676 and 779 I added an extra set of brackets. In the
"if" clause as a whole there were a mix of && and || used that were
relying on the PHP standard that && has precedence over ||
In actual fact the original code should have been working fine, the...

Code style guide changes for filter.inc 2nd version

This is the changes to filter.inc as per the commits in https://github.com/pfsense/pfsense/pull/1521 but done in just 1 clean commit.

Fix type (trime->trim)

Fix indent and remove some unecessary ()

Merge pull request #1520 from phil-davis/Code-Style-Guide-etc-inc-a-to-e

Merge pull request #1519 from phil-davis/Code-style-etc-misc

Merge pull request #1516 from phil-davis/patch-2

Merge pull request #1515 from phil-davis/Style-updates

Code Style Guide etc inc f to g

remove unused legacy code

Log ifconfig commands used to setup wireless interfaces

Code style guide etc in a to e

Code style guide changes for miscellaneous files

under etc

Put the bits to use the new reset utility

interface_netgraph_needed can miss setting found equals true

This routine seems to go looking to see if the passed-in interface is PPP-style. At the end, if it is not PPP-style then it calls pfsense_ngctl_detach.
This foreach loop in its current state will always exit after the first iteration that is not mode "server". But it looks like it should look through all the 'pppoe' entries until it finds the interface or gets to the end....

Ticket #4418 Actually make each entry a clear token to strongswan parser for dns_split

Ticket #4418 make sure the dns_split is separated with spaces rather than space or comma to comply with strongswan requirements.

Ticket #4418 Make the DNS names attr 28675 space separated as identified by Jeffrey Dvornek

remove old, unused code

Minor spacing edits to etc files

Code style for etc files

Initialize var and move unset outside the loop

Merge pull request #1495 from k-paulius/fix-dhcp6c-4436

Merge pull request #1479 from surrural/master

Merge pull request #1498 from phil-davis/patch-3

Merge pull request #1513 from znerol/bug/master/unbound-host-alias-ptr-followup

Fix PTR records for aliases in host overrides

Add support for DNSimple (dnsimple.com)

Update dyndns.class

Add support for DNSimple (dnsimple.com)

Add support for DNSimple (dnsimple.com)

Merge pull request #1511 from phil-davis/patch-4

Merge pull request #1477 from razzfazz/fix_net_ipv6_compress_all_zeroes_master

Preserve "add routers" value across loop for each interface

Forum: https://forum.pfsense.org/index.php?topic=89302.0

If the user put "none" in the 'gateway' field for the DHCP settings of an interface, that would set $add_routers to false at line 742. Coming around the loop again for a subsequent interface, and going through the else line 744, nothing would set $add_routers back to true (actually back to the value originally calculated at line 461)....

Merge pull request #1496 from stilez/patch-2

Merge pull request #1476 from razzfazz/fix_dns6ip_assignment_for_track6_master

Do not add PTR records for aliases in host overrides

Merge pull request #1508 from johnbyronent/master

Clean up some old, possibly stale, files when restarting php-fpm

add a couple unnecessary bsdinstaller files to obsoletedfiles

remove unused dfuife files.

Handle reverse lookup domain overrides

that match exactly a whole block of private address space.
e.g. if the user has checked "Do not forward private reverse lookups" and also adds adds a domain override that matches a whole block of private address space, such as:...

Don't hard code harden-referral-path. It defaults to no, so no behavior change, and that setting is unlikely to ever become a default. This allows users to configure an override to enable this option if desired. part of Ticket #4399

Add GUI control for MOBIKE. Hide it when IKEv1 selected. Enable toggling of NAT-T field display so it's on for IKEv1, off for IKEv2. Do same for reauth while here. Ticket #3979

Wait a bit after sending a TERM to syslogd as in some instances it can take too long to stop, and it fails to restart because it's still running at that point. Add a KILL in case it's still running after that. Ticket #4393

Three minor improvements to IP functions

1) Most is_ip***() functions can return 4 or 6 to indicate type of IP, for benefit of calling code (both evaluate to boolean TRUE for backwards compatibility). But is_ipddr() doesn't. Fix is_ipaddr() so it follows same result schema. This saves calling code having to retest same data to determine type....

Do not request prefix delegation if no tracking interfaces are setup to
use it. Ticket #4436

Unobsolete libpcre.so.1

Merge pull request #1484 from phil-davis/more-text-typos

Surrond the some mobile clients attributes with " ( quote ) to help the strongswan parser identify properly the values. Ticket #4418

Unobsolete crypto tools and athstats, ticket #4239

DHCPv6 client rules MUST come before bogons. Add a comment that hopefully
sticks out so this stops getting broken. Ticket #3395

Ticket #4390 Return only the subnet bits not the full network in cidr format.

Fixes #4389 The VIP interfaces cannot be assigned since they are just an identification of the VIP for tracking. Consider that when configuring gif/gre. Also on bridges you cannot set a vip interface as its member.

Random text typos

and I "corrected" function names that had "_choosen_" in them.
That is not technically an error - function names do not have to be
English words. But it does look nicer to read.

Merge pull request #1480 from phil-davis/patch-1

Merge pull request #1482 from phil-davis/CP-text-typos

Remove unset variable, spotted by phil-davis

rrset-cache-size should == 2 * msg-cache-size. Ticket #4367

Random text typos

that I noticed.

Fixes #4370 Use the curlies to not confuse php

Actually fix even the openvpn auth user script with proper checks. I thought this was fixes already!

Fixes #4329, Fix even tls.auth script by using proper isset() test as the fixes for other authentication scripts.

Fixes #4397 Make mtu configuration before the ip address assignment. This fixes the issues of link routes having the wrong mtu configured on them.

Check if notification is disabled

in send_smtp_message()
Other packages like arpwatch sm.php and cron job output as reported in forum https://forum.pfsense.org/index.php?topic=88347.0 call send_smtp_message() directly, currently bypassing notification disabled checks. I think those packages [are intended to | should be] respecting the notifications disabled setting. People in the forum certainly expect them to respect this setting....

also add v6 IPs to hosts in the same manner v4 IPs are added. Ticket #4395

Merge pull request #1469 from makkbe/master

fix Net_IPv6::compress() to properly handle all-zeros address

The existing implementation of Net_IPv6::compress produces an empty
string when compressing the all-zeros ("::") address; fix this by
checking for empty return values and replacing them with "::".

add dhcp6.name-servers option with DHCPD-PD regardless of PD length

The existing code only includes a v6 name server IP in the
automatically generated dhcpdv6 configuration for tracking interfaces if
there are additional prefixes that can be delegated on to the next...

remove CGN from "Block private networks" as it was in 2.0x and earlier
releases since it specifically notes RFC 1918 and CGN is more bogon.
Ticket #4379

Fixes #4381 this was a leftover of the change of zoneids to start from 2.

Merge pull request #1472 from bassebaba/master

Merge pull request #1455 from xbipin/patch-2

Use web-gui setting for pap or chap instead of having it hard-coded to chap.

remove empty values

remove empty values

upgrade config

upgrade config code so old entries not lost during upgrade

Merge pull request #1470 from phil-davis/patch-1

Fix restartipsec command line script.

Fixes #3669 Handle properly recording of the ipv6 interface new ip and do not issues commands that cannot succeed.

In last case, use dmesg.boot do detect ALIX boards when hw.model is not enough

Silent kenv when smbios.system.product is not present. While here, add VirtualBox to the list of virtualenvs

Firmware upgrade script text changes

while I am looking at this, might as well correct these.
No function problems or impact.

Added DynDNS support for GleSYS API (www.glesys.com).

Allow IPseec clients to properly connect and not stomp over each other. Reported-by https://forum.pfsense.org/index.php?topic=87980.0

Properly calculate the 6rd default gateway honoring netmasks other than /32

Ticket #4353 fix typo on unset var spotted-by: Phil Davis

Merge pull request #1459 from PiBa-NL/speedup_is_port

need $g here so product_name is set in user agent

Fixes #4360 allow marking a connection as responder only, the same behviour as mobile connections

Fixes #4359 Allow controlling uniqueids

speedup 'function is_port($port)' speed by skipping calls to getservbyname when possible

Fixes #4353 Identify when strongswan.conf needs a reload and restart ipsec service.

Merge pull request #1456 from phil-davis/patch-1

Fixes #4340 encode username same as with password to avoid issues with special chars.

Firewall Log does not display logged IGMP packets

If IGMP packets are logged (either pass or block) then parse_filter_line did not set their src and dst IP.
Later in the subroutine, it zapped the filter line because it did not have a src and dst.
This fixes it. Now the IGMP lines in /var/log/filter.log appear on the Firewall Log GUI.