pfSense

Fixed #5733

Correct "noWrap" in text areas. (Function is not actually used by anyone, but it might as well work just in case.

Merge pull request #2351 from NOYB/HTML_Compliance_-_Firewall_/_NAT/_1_1_/_Edit

Redmine #5731 Error when setting various system log settings from factory default config

Forum https://forum.pfsense.org/index.php?topic=104762.0

HTML Compliance - Firewall / NAT/ 1:1 / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="src" id="src" type="text" pattern="[0-9, a-z, A-Z and .">
<input class="form-control" name="dst" id="dst" type="text" pattern="[0-9, a-z, A-Z and .">

Redmine #5728 Fix delete row button in Firewall Schedule Edit

The calls to delete_row() were going off to some other delete_row() function and not doing what was needed.
Give delete_row() here a unique name and it all works again.

Merge pull request #2347 from NOYB/HTML_Compliance_-_Firewall_/_NAT_/_Port_Forward_/_Edit

Merge pull request #2346 from NOYB/HTML_Compliance_-_Firewall_/_Aliases_/_Edit

Merge pull request #2345 from NOYB/HTML_Compliance_-_Services_Status_Widget

HTML Compliance - Firewall / NAT / Port Forward / Edit

Attribute min/max not allowed on element input at this point.
<input class="form-control" name="srcbeginport_cust" id="srcbeginport_cust" type="text" value="any" min="1" max="65536">
<input class="form-control" name="srcendport_cust" id="srcendport_cust" type="text" value="any" min="1" max="65536">...

Fix reading of server list on page load

Fixed #5724

HTML Compliance - Firewall / Aliases / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="address0" id="address0" type="text" value="" pattern="[0-9, a-z, A-Z and ." placeholder="Address">

HTML Compliance - Services Status Widget

Element option without attribute label must not be empty.
<option selected></option>

Merge pull request #2341 from NOYB/HTML_Compliance_-_Interfaces_/_VLAN

Merge pull request #2339 from BBcan177/patch-2

HTML Compliance - Interfaces / VLAN

A table row was 5 columns wide and exceeded the column count established by the first row (4).

pkg_mgr_installed - Fix disablepackagehistory

• Improve if/else/endif

pkg_mgr - Fix disablepackagehistory

• Version title should always print
• $g['disablepackagehistory'] only disables the changelog hyperlink

Fixed #5717

Merge pull request #2325 from stilez/patch-7

Merge pull request #2337 from BBcan177/patch-1

Update pkg_mgr.php

Update syntax to 4 space indent

Add password confirmation and change to Form_* framework

Update pkg_mgr.php

• Note - There are two lines previously commented out at Lines! (L127-128)

• Mods to if/else/elseif/endif statements for consistency.
• Change package dependency href link icon from "paper-clip" to "globe".
• Put package dependency links into a < ul > for a cleaner output when dependencies span over two lines....

Merge pull request #2335 from NOYB/HTML_Compliance_-_Interfaces_/_Assign_network_ports

Merge pull request #2334 from BBcan177/patch-2

Fix typo password confirm

https://forum.pfsense.org/index.php?topic=104629.0

HTML Compliance - Interfaces / Assign network ports

A table row was 3 columns wide and exceeded the column count established by the first row (2).

Update pkg_mgr_installed.php

• Mods to if/else/elseif/endif statements for consistency.
• Change font red to span class.
• Change package dependency href link icon from "paper-clip" to "globe".
• Remove redundant <i> in package dependency href link
• Put package dependency links into a <ul> for a cleaner output when dependencies span over two lines....

Add output validation here too. Ticket #5351

complete breadcrumbs for each tab

No need to restart dpinger to get new rrd data, it's not like apinger that send data to rrd

Fixed #5694

Final updates in support of hidden passwords

Merge pull request #2333 from NOYB/HTML_Compliance_-_System_/_User_Manager_/_Users

Correction to #5710

Fixed #5710

HTML Compliance - System / User Manager / Users

A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.

Fixed saving password when the ols password needs to be retained

Merge pull request #2331 from BBcan177/patch-1

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Add href for package dependencies (pkg_mgr_installed)

• Case typo
• Change package dependency text to href link(s).

Merge pull request #2330 from ExolonDX/master

Don't display dummy password if configured pwd is empty

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Update "firewall_aliases.php"

Add Bootstrap panels to "firewall_aliases.php"

Fixes issue where limiter mask does not save (from forum)

Change alert box color to success

Merge pull request #2321 from ch1c4um/Fix_dns_resolver

HTML Compliance - System / Package Manager / Available Packages

Bad value #search-panel .panel-body for attribute href on element a: Illegal character in fragment: space is not allowed.
<a data-toggle="collapse" href="#search-panel .panel-body" name="search-panel">...

Fixed #5697

Merge pull request #2327 from NOYB/HTML_Compliance_-_System_/_Package_Manager_/_Available_Packages

Merge pull request #2326 from NOYB/HTML_Compliance_-_System_/_Certicate_/_CAs

Alternative to PR 2324 - Remove unneeded div

HTML Compliance - System / Package Manager / Available Packages

Stray tbody, table, and div tag ends when list empty.
Close php tag.

HTML Compliance - System / Certicate / CAs

Close div tag
Close php tag

Redundant logic tests in a range check

The logic here is redundant. It tests IP1<START || IP2<START || IP1>END || IP2>END. Then it tests if IP1<IP2 unsigned.

If the latter test succeeds (ie test that first) then IP1>=START must imply IP2>=START and IP2<=END must imply IP1<=END. In other words we only need to test:...

Update pkg_edit.php

• Incorrect variable name in pkg_edit

clarify text, might not apply to "NIC" (lagg, VLANs, etc.)

Fixed #5691

HTML Compliance - System / Advanced / Firewall and NAT

Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.
<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">...

Merge branch 'master' of git.pfmechanics.com:pfsense/pfsense

fix part of #5604

Added support for <width> on inouts and aliases.

Add title to add row buttone

Fixed #5668

Fixed bug to disable dns resolver service

Take this conditional out, it wasn't enough, and we have a script example for how to handle this properly now while respecting CSRF

Merge pull request #2319 from NOYB/HTML_Compliance_-_System_/_Advanced_/_Admin_Access

Merge pull request #2318 from phil-davis/patch-2

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

This would require some minor adjustments to the wizards xml , for it to make sense everywhere.

HTML Compliance - System / Advanced / Admin Access

Close div tag
Close php tag

LAGG edit fixes

1) $_POST['members'] is an array, but $pconfig['members'] should be a comma-separated list. So the general copy "$pconfig = $_POST;" needs to be followed by setting up 'members' in particular.
2) $members_array is never used - so throw it away....

Add trash can icon to rowhelper delete buttons

Remove name collision in $width attribute

Accommodate <width> XML tag in rowhelper input fields

Move width:auto style to textarea handler in pkg_edit.php

Merge pull request #2316 from phil-davis/patch-3

Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_Placeholder

Merge pull request #2311 from heper/patch-1

Adds support for <width> XML tag in rowhelper selects

HTML Compliance - Form Select 3rd try

This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315

Default textarea width to 60 cols.
Use setCols() to override

Adds style="width: auto;" attribute to textareas to allow the "cols" attribute to take effect. Required bu pkg_edit.php and by wizards

Reverts change to Form_Selector which was breaking selectors with blank options

Modify CSS to allow caller to specify width

Bug #5527

Bug #5527

Update system_gateway_groups_edit.php

Bug #5527

Bug #5527

Bug #5527

bug #5527

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php