Project

General

Profile

« Previous | Next » 

Revision 0027de0a

Added by Ermal Luçi about 16 years ago

  • Create two new functions lock($subsystem)/unlock() to have more reliable locking using semaphores.
    This function can sleep till the resource is free and can help find not well behaving code.
  • Remove most of the config_lock/config_unlock logics on the whole scripts/pages it is an abuse of this.
    If any sybsytem wants to lock can do so with its own lock.
  • Lock the config when doing a filter reload to avoid parallell recursion on this function, since it is not reentrant.
    This compenstates for the removal of lock aquiring from the scripts/pages.
  • config_lock/config_unlock are now compate shims that do nothing. They are preserved since packages 'abuse' them too.

View differences:

usr/local/www/diag_logs_settings.php
89 89 
		write_config();
90 90 

  		




  91
  91
  
    
		$retval = 0;


  		




  92
  
  
    
		config_lock();


  		




  93
  92
  
    
		$retval = system_syslogd_start();


  		




  94
  93
  
    
		if ($oldnologdefaultblock !== isset($config['syslog']['nologdefaultblock']))


  		




  95
  94
  
    
			$retval |= filter_configure();


  		




  96
  
  
    
		config_unlock();


  		




  97
  95
  
    

  		




  98
  96
  
    
		$savemsg = get_std_save_message($retval);


  		




  99
  97
  
    
	}


  		












Also available in:  Unified diff