Project

General

Profile

« Previous | Next » 

Revision 0027de0a

Added by Ermal Luçi about 16 years ago

  • Create two new functions lock($subsystem)/unlock() to have more reliable locking using semaphores.
    This function can sleep till the resource is free and can help find not well behaving code.
  • Remove most of the config_lock/config_unlock logics on the whole scripts/pages it is an abuse of this.
    If any sybsytem wants to lock can do so with its own lock.
  • Lock the config when doing a filter reload to avoid parallell recursion on this function, since it is not reentrant.
    This compenstates for the removal of lock aquiring from the scripts/pages.
  • config_lock/config_unlock are now compate shims that do nothing. They are preserved since packages 'abuse' them too.

View differences:

usr/local/www/vpn_pppoe_users.php
50 50

  
51 51
	if ($_POST['apply']) {
52 52
		$retval = 0;
53

  
54
		config_lock();
55 53
		$retval = vpn_setup();
56
		config_unlock();
57

  
58 54
		$savemsg = get_std_save_message($retval);
59 55
		if ($retval == 0) {
60 56
			if (file_exists($d_pppoeuserdirty_path))

Also available in: Unified diff