Project

General

Profile

« Previous | Next » 

Revision 5319cf40

Added by Talle over 9 years ago

Change comparison of username to certificate common name to be safer and case insensitive

Currently the username is compared against the common name using a standard PHP comparison,
this is unsafe because it might do unintended type conversions. So change the != comparison to
an !== comparison to make sure the types match.

Since usernames on Windows sytstems are not case-sensitive and prone to case differences in
user input or auto filled fields we should allow case differences between the username and the
certificate common name.

  • added
  • modified
  • copied
  • renamed
  • deleted