Project

General

Profile

« Previous | Next » 

Revision 72992b85

Added by Chris Buechler over 10 years ago

There is no longer any need to restrict protocols for IPv4+IPv6 rules, the appropriate ruleset is generated and problem scenarios that would otherwise break here are prevented by other input validation.

View differences:

usr/local/www/firewall_rules_edit.php
298 298 
			$input_errors[] = gettext("You can not assign an IPv6 Gateway to an IPv4 Filter rule");
299 299 
		}
300 300 
	}
301 

  		




  302
  
  
    
	if (($_POST['proto'] != "tcp") && ($_POST['proto'] != "udp") && ($_POST['proto'] != "tcp/udp") && ($_POST['proto'] != "icmp")) {


  		




  303
  
  
    
		if($_POST['ipprotocol'] == "inet46")


  		




  304
  
  
    
			$input_errors[] =  gettext("You can not assign a protocol other than ICMP, TCP, UDP or TCP/UDP to a rule that applies to IPv4 and IPv6");


  		




  305
  
  
    
	}


  		




  306
  301
  
    
	if (($_POST['proto'] == "icmp") && ($_POST['icmptype'] <> "")){


  		




  307
  302
  
    
		if($_POST['ipprotocol'] == "inet46")


  		




  308
  303
  
    
			$input_errors[] =  gettext("You can not assign a ICMP type to a rule that applies to IPv4 and IPv6");


  		












Also available in:  Unified diff