Project

General

Profile

Actions

Todo #1071

closed

Reevaluate locks

Added by Erik Fonnesbeck over 13 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
12/05/2010
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

Since the change to the lock function in util.inc to make shared locks the default instead of exclusive locks, most locks have been effectively nonexistent (currently only the config library uses exclusive locking at all). Code that only reads and does not write can probably continue to use the shared locks, but code that does writing or is non-reentrant for any other reason should probably have the locks made exclusive (LOCK_EX).

Some places where this may need to be checked include captive portal, vouchers, and filter reload, but there may be others.

Actions

Also available in: Atom PDF