Project

General

Profile

Actions
Copy link

Bug #13088

closed

Rapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert

Added by Phil Wardt over 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
OpenVPN
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

in client specific overrides, NTP and DNS options: use javascript instead of toggles class because the latter causes inverted results when repeating clicks too quickly. This also matches the code used in the server page

Completes OpenVPN GUI fixes:
https://redmine.pfsense.org/issues/13087

Files

vpn_openvpn_csc.patch (2.71 KB) vpn_openvpn_csc.patch Phil Wardt, 04/22/2022 10:49 AM
Actions
Copy link
 #2

Updated by Danilo Zrenjanin over 2 years ago

I replicated the issue with inverted results when repeating clicks too quickly on 22.05.r.20220604.1403.

After applying the patch, it works fine.

Actions
Copy link
 #3

Updated by Danilo Zrenjanin almost 2 years ago

  • Status changed from New to Pull Request Review

I can confirm this behavior is present on the:

22.05-RELEASE (amd64)
built on Wed Jun 22 18:56:13 UTC 2022
FreeBSD 12.3-STABLE

The patch fixes the issue. It can be merged.

Actions
Copy link
 #4

Updated by Lev Prokofev almost 2 years ago

Can't replicate the issue on

23.05-DEVELOPMENT (amd64)
built on Mon Jan 09 06:04:59 UTC 2023
FreeBSD 14.0-CURRENT

Actions
Copy link
 #5

Updated by Lev Prokofev almost 2 years ago

Correcting,

Replicable on 23.05 and 23.01

Actions
Copy link
 #6

Updated by Jim Pingle almost 2 years ago

  • Target version set to 2.7.0
  • Plus Target Version set to 23.05
Actions
Copy link
 #7

Updated by Jim Pingle over 1 year ago

  • Plus Target Version changed from 23.05 to 23.09
Actions
Copy link
 #8

Updated by Jim Pingle over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

Working OK on the latest build as far as I can tell.

Actions
Copy link
 #10

Updated by Jim Pingle over 1 year ago

  • Subject changed from OpenVPN Client Overrides: properly hide/show form fields to Rapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF