Project

General

Profile

Actions
Copy link

Feature #13103

closed

Warn the user if they attempt to disable SSH from the menu while connected through SSH

Added by → luckman212 over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Console Menu
Target version:
2.7.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default

Description

Believe it or not, I fat fingered "13" the other day and typed "14" instead when connected via SSH ... and hit "y" which then locked me out of a firewall. Had to dig out the console cable to get it sorted.

This small patch just checks to see if the current session is via SSH and if so, it prints a warning if the user is about to footgun themselves.

Screenshot:

Actions
Copy link
 #2

Updated by Danilo Zrenjanin over 2 years ago

I tested the commit. It is pretty helpful and works as expected.

Actions
Copy link
 #3

Updated by Jim Pingle over 2 years ago

  • Subject changed from add warning to rc.initial menu if disabling sshd (opt 14) would kill your current session to Warn the user if they attempt to disable SSH from the menu while connected through SSH
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions
Copy link
 #4

Updated by Viktor Gurov over 2 years ago

  • Status changed from New to Feedback

PR merged, thanks!

Actions
Copy link
 #5

Updated by Danilo Zrenjanin over 2 years ago

  • Status changed from Feedback to Resolved

Tested:

22.05-DEVELOPMENT (amd64)
built on Thu May 05 06:21:31 UTC 2022
FreeBSD 12.3-STABLE

It works as expected.

Actions
Copy link

Also available in: Atom PDF