Bug #6420
closed
Monitoring graphs last sample being zero
0%
Description
When there is no RRD data sample for the current minute the graph, last, and minimum data values are zero in certain circumstances. Such as resolution 1 minute and graph loaded prior to the current minute RRD sample being saved. This is also similar for the first minute of other resolutions.
This PR corrects this.
https://github.com/pfsense/FreeBSD-ports/pull/139
Updated by Chris Buechler almost 8 years ago
- Category set to RRD Graphs
- Status changed from New to Feedback
something similar to that PR was merged
Updated by Jared Dillard almost 8 years ago
I created a new ticket for the issues with the custom time period since they will require a little more tweaking than the presets, which PR 139 (mentioned above) mainly addressed:
https://redmine.pfsense.org/issues/6477
This ticket, 6420, should just apply to the preset time periods, in an effort to keep things clean.
Updated by NOYB NOYB almost 8 years ago
Feedback:
Time period is 1 resolution too long.
Using larger (later) of left/right updated, instead of smaller (earlier), can result in zero ending value of the other.
This commit handles both of those.
https://github.com/pfsense/FreeBSD-ports/pull/145/commits/3d5e745943c8fb34c072b66116bc66827cf7b0a7
Updated by Chris Buechler almost 8 years ago
- Status changed from Feedback to Resolved
Updated by NOYB NOYB almost 8 years ago
Chris Buechler wrote:
last of that fixed in
https://github.com/pfsense/FreeBSD-ports/commit/6555d100423fc7b913ff3976feba5c756fbb0251
Umm, no it wasn't. Not sure where feedback was coming from that said it was fixed. But it is not.
Though PR 145 does.
https://github.com/pfsense/FreeBSD-ports/pull/145/files
Perhaps you were thinking of this ticket. Which does appear to be fixed.
https://redmine.pfsense.org/issues/6334
Updated by Chris Buechler almost 8 years ago
- Status changed from Resolved to Assigned
- Target version changed from 2.3.1-p2 to 2.3.2
- Affected Version changed from 2.3 to 2.3.x
NOYB NOYB wrote:
Umm, no it wasn't. Not sure where feedback was coming from that said it was fixed. But it is not.
Though PR 145 does.
https://github.com/pfsense/FreeBSD-ports/pull/145/files
Was taking Jared's word on it. He might have confused it with something diff.
Updated by Chris Buechler almost 8 years ago
- Target version changed from 2.3.2 to 2.4.0
Updated by Renato Botelho over 6 years ago
- Target version changed from 2.4.0 to 2.4.1
Updated by Kill Bill over 6 years ago
Been fixed with https://github.com/pfsense/FreeBSD-ports/commit/5b20ed3661e6dc6d8b8d3c78aab5784556cc0dc3 almost a year ago.
Updated by Jim Pingle over 6 years ago
- Status changed from Assigned to Resolved