Project

General

Profile

Actions

Bug #10168

closed

firewall_rules_edit.php: Firewall GUI allows selecting 'not' and 'any' for source/destination which is invalid

Added by Jim Pingle almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
01/07/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

On firewall_rules_edit.php, the GUI allows selecting 'not' and 'any' together for source/destination which is invalid as it could never match anything. The backend code in filter.inc detects this and ignores the 'not' in this case. The GUI should reject it similarly with input validation to warn the user.

Actions #1

Updated by Jim Pingle almost 2 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Viktor Gurov almost 2 years ago

  • Status changed from Feedback to Resolved

Jim Pingle wrote:

Applied in changeset 40baab141eb30b11b57efa0cf14521021aa7b4c7.

tested on 2.4.5.a.20200107.1903
works as expected

Actions

Also available in: Atom PDF