Project

General

Profile

Actions
Copy link

Bug #10249

closed

Syntax error in filter.inc with 2.4.5.r.20200210.1126 introduced in revision a3ab75ba7d9632eba2dee0d2a1d986949d207ce4

Added by Grimson Gretzleburg almost 5 years ago. Updated almost 5 years ago.

Status:
Duplicate
Priority:
Urgent
Assignee:
Jim Pingle
Category:
Operating System
Target version:
-
Start date:
02/10/2020
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5
Affected Architecture:

Description

Here is the crash report:

Crash report begins. Anonymous machine information:

amd64
11.3-STABLE
FreeBSD 11.3-STABLE #93 54b0ad59490(RELENG_2_4_5): Mon Feb 10 11:27:17 EST 2020 :/build/ce-crossbuild-245/obj/amd64/IuZS8Bew/build/ce-crossbuild-245/sources/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[10-Feb-2020 18:40:32 Europe/Berlin] PHP Parse error: syntax error, unexpected ']' in /etc/inc/filter.inc on line 2390
[10-Feb-2020 18:42:05 Europe/Berlin] PHP Parse error: syntax error, unexpected ']' in /etc/inc/filter.inc on line 2391

This prevents a normal boot and requires shell access to fix.

Actions
Copy link
 #1

Updated by Jim Pingle almost 5 years ago

  • Status changed from New to Duplicate
  • Assignee set to Jim Pingle

Fixed on #10246

Actions
Copy link
 #2

Updated by Grimson Gretzleburg almost 5 years ago

Jim Pingle wrote:

Fixed on #10246

Nope you introduced a new syntax error that prevents filter.inc from working and pfSense from fully starting up. See lines 2390 and 2391:

                if ($dstaddr_port[count($dstaddr_port)-1]]) {

                    $dstaddr_reflect .= " port " . $dstaddr_port[count($dstaddr_port)-1]];

it should be:

                if ($dstaddr_port[count($dstaddr_port)-1]) {

                    $dstaddr_reflect .= " port " . $dstaddr_port[count($dstaddr_port)-1];

Edit ok now #10246 shows newer commits fixing the issue. You might want to remove the above 2.4.5.r.20200210.1126 snapshot or put up a warning on the forums/reddit.

Actions
Copy link
 #3

Updated by Jim Pingle almost 5 years ago

Check the issue again. There is a later commit which corrects the error.

Actions
Copy link

Also available in: Atom PDF