Project

General

Profile

Actions

Bug #1030

closed

Interface case change in apinger.conf needs reverted

Added by Chris Buechler about 14 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
RRD Graphs
Target version:
-
Start date:
11/22/2010
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.0
Affected Architecture:

Description

Interfaces are showing in upper case in apinger's conf now, splitting the RRDs into two different graphs. Unknown impact on 1.2.x upgraded systems, but enough 2.0 installs out there that it needs to go back.

Actions #1

Updated by Scott Ullrich almost 14 years ago

  • Status changed from New to Feedback

Reverted offending commits. Please test.

Actions #2

Updated by Jeppe Oland almost 14 years ago

Not sure it works (pfSense-2.0-BETA4-20101201-1616.iso).
I restored my configuration just before midnight, and the RRD directory looks like this now:

rw-r--r- 1 nobody wheel 47608 Dec 2 01:32 WAN-quality.rrd
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 ipsec-packets.rrd
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 ipsec-traffic.rrd
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 lan-packets.rrd
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 lan-traffic.rrd
rw-r--r- 1 nobody wheel 727424 Dec 2 01:31 system-memory.rrd
rw-r--r- 1 nobody wheel 243328 Dec 2 01:31 system-processor.rrd
rw-r--r- 1 nobody wheel 243328 Dec 2 01:31 system-states.rrd
rw-r--r- 1 root wheel 3465 Dec 1 23:52 updaterrd.sh
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 wan-packets.rrd
rw-r--r- 1 nobody wheel 47608 Dec 1 23:50 wan-quality.rrd
rw-r--r- 1 nobody wheel 194776 Dec 2 01:31 wan-traffic.rrd

The config file I restored had both a "WAN-quality.rrd" file (listed as the first one in the config file) and a "wan-quality.rrd" file.
As you can see from the dates, only the uppercase file is being updated with new data.
The only other mention of uppercase WAN in the config file is the "descr" field for the "wan" interface.

Actions #3

Updated by Chris Buechler almost 14 years ago

  • Status changed from Feedback to New

That revert was correct but not for fixing this.

Actions #4

Updated by Ermal Luçi almost 14 years ago

Well seems ok now.
Chris why do you think this is not fixed?

Actions #5

Updated by Chris Buechler almost 14 years ago

The quality RRDs are still using the uppercase interface name, where they previously always used lowercase and still should. Hence WAN-quality and wan-quality above.

Actions #6

Updated by Ermal Luçi almost 14 years ago

That is the gateway quality graph not the interfaces one :)
As far as i can tell the interface graphs all use the not uppercase version.

Actions #7

Updated by Jeppe Oland almost 14 years ago

For me, the quality graph was always the offending one.

Actions #8

Updated by Ermal Luçi almost 14 years ago

Well that has changes since long time now.
It is more than 5-6 months it has changed!

Actions #9

Updated by Jeppe Oland almost 14 years ago

Changed to uppercase you mean?
I guess the question is: Should it also be reverted to lowercase?
(I think it should be lowercase since thats what it's always been, and it matches the other interface files)

Actions #10

Updated by Ermal Luçi almost 14 years ago

Well as it is now it cannot use any lowercase name since it uses the gateway name!
Possibly on 2.x++ this can be fixed by giving a reference to the gateways to use in the name. Mostly this is a limitation to what apinger can pass back as information to match the status.

Actions #11

Updated by Ermal Luçi almost 14 years ago

  • Target version changed from 2.0 to Future
Actions #12

Updated by Jeppe Oland almost 14 years ago

I guess it should be mentioned in the release notes at some point then, as many people will have the problem.

Or preferably, the upgrade/backup restore procedure should simply rename the old lowercase file to uppercase.

FWIW, I user the merge-rrd python script to merge my 2 files together, and it looks like it worked fine.

Actions #13

Updated by Chris Buechler over 13 years ago

  • Status changed from New to Closed
Actions #14

Updated by Chris Buechler over 8 years ago

  • Target version deleted (Future)
Actions

Also available in: Atom PDF