Project

General

Profile

Actions
Copy link

Bug #10355

closed

diag_ping.php: Potential XSS via Hostname parameter

Added by Jim Pingle almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Diagnostics
Target version:
2.4.5
Start date:
03/18/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

On diag_ping.php, the hostname isn't fully validated and the output is not encoded, leading to a potential XSS.

Using an input such as the following example demonstrates the problem:

127.0.0.1 <img src='' onerror='alert()'>
Actions
Copy link
 #1

Updated by Jim Pingle almost 5 years ago

diag_traceroute.php is unaffected but I made the same changes there to be safe.

Actions
Copy link
 #2

Updated by Jim Pingle almost 5 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Jim Pingle almost 5 years ago

  • Status changed from Feedback to Resolved

Improper input is rejected by validation on 2.4.5.r.20200318.1200

Actions
Copy link
 #4

Updated by Jim Pingle over 4 years ago

  • Private changed from Yes to No
Actions
Copy link

Also available in: Atom PDF