Project

General

Profile

Actions

Bug #10542

closed

Exclamation marks in the description field of a floating rule result in a filter reload error.

Added by Léa Al about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
05/09/2020
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5
Affected Architecture:

Description

Some characters such as "/!\" in a floating rule description produce an error when the filter is reloaded.

Steps to reproduce :
  • Create a floating rule with the following description: /!\ TEMP /!\
  • Click "Apply Changes"
  • Open the notices to view the error

Error:

There were error(s) loading the rules: /tmp/rules.debug:128: syntax error - The line in question reads [128]: pass in quick on [...]

Actions #1

Updated by Viktor Gurov about 2 years ago

The '\' character is not allowed in the Description field.
All other special characters are OK

Fix:
https://github.com/pfsense/pfsense/pull/4313

Actions #2

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.4.5-p1
Actions #3

Updated by Jim Pingle about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Jim Pingle

PR merged

Actions #4

Updated by Jim Pingle about 2 years ago

  • Status changed from Feedback to Resolved

Description with \ is rejected as expected. Without that character, the description is accepted and works.

Actions #6

Updated by Jim Pingle almost 2 years ago

That makes sense, many parsers treat \ at the end of a line as an instruction to join it with the following line.

The safest course of action is probably to deny it as we have done, as that also means it could possibly be used to make escape characters inside the description.

Actions

Also available in: Atom PDF