Actions
Bug #10542
closed
Exclamation marks in the description field of a floating rule result in a filter reload error.
Start date:
05/09/2020
Due date:
% Done:
0%
Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5
Affected Architecture:
Description
Some characters such as "/!\" in a floating rule description produce an error when the filter is reloaded.
Steps to reproduce :- Create a floating rule with the following description: /!\ TEMP /!\
- Click "Apply Changes"
- Open the notices to view the error
Error:
There were error(s) loading the rules: /tmp/rules.debug:128: syntax error - The line in question reads [128]: pass in quick on [...]
Updated by Viktor Gurov almost 4 years ago
The '\' character is not allowed in the Description field.
All other special characters are OK
Updated by Jim Pingle almost 4 years ago
- Status changed from New to Pull Request Review
- Target version set to 2.4.5-p1
Updated by Jim Pingle almost 4 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Jim Pingle
PR merged
Updated by Jim Pingle almost 4 years ago
- Status changed from Feedback to Resolved
Description with \ is rejected as expected. Without that character, the description is accepted and works.
Updated by Viktor Gurov almost 4 years ago
seems related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182819
Updated by Jim Pingle almost 4 years ago
That makes sense, many parsers treat \ at the end of a line as an instruction to join it with the following line.
The safest course of action is probably to deny it as we have done, as that also means it could possibly be used to make escape characters inside the description.
Actions