Bug #11741: VLAN 1 description displays as "Default System VLANDefault System VLAN" - pfSense Plus - pfSense bugtracker

Actions

Copy link

Bug #11741

closed

VLAN 1 description displays as "Default System VLANDefault System VLAN"

Added by → luckman212 about 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Web Interface

Target version:

Start date:

03/27/2021

Due date:

% Done:

Estimated time:

Release Notes:

Default

Affected Plus Version:

Affected Architecture:

SG-2100

Description

In the GUI, the description for the default VLAN is printed twice:

I made a simple fix for this, here's a patch:

365,373c365,375
<         if (!$sys && $platform['name'] == 'uFW') {
<             $vlan = find_pfSense_vlan($vgroup['vid']);
<             if ($vlan != NULL && is_array($vlan)) {
<                 $switch_table .= htmlspecialchars($vlan['vlan']['descr']);
<             }
<         } else {
<             $descr = get_config_descr($swid, $vgroup['vlangroup']);
<             if ($descr != NULL) {
<                 $switch_table .= htmlspecialchars($descr);
---
>         if (!$sys) {
>             if ($platform['name'] == 'uFW') {
>                 $vlan = find_pfSense_vlan($vgroup['vid']);
>                 if ($vlan != NULL && is_array($vlan)) {
>                     $switch_table .= htmlspecialchars($vlan['vlan']['descr']);
>                 }
>             } else {
>                 $descr = get_config_descr($swid, $vgroup['vlangroup']);
>                 if ($descr != NULL) {
>                     $switch_table .= htmlspecialchars($descr);
>                 }