Project

General

Profile

Actions
Copy link

Bug #11765

closed

Invalid HTML encoding in modal Notices window

Added by Viktor Gurov over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Notifications
Target version:
2.5.2
Start date:
04/01/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:

Description

In some cases it shows "&lt;head&gt" instead of "<head>":

https://acb.netgate.com/save (&amp;lt;html&amp;gt;
&amp;lt;head&amp;gt;&amp;lt;title&amp;gt;500 Internal Server Error&amp;lt;/title&amp;gt;&amp;lt;/head&amp;gt;
&amp;lt;body&amp;gt;
&amp;lt;center&amp;gt;&amp;lt;h1&amp;gt;500 Internal Server Error&amp;lt;/h1&amp;gt;&amp;lt;/center&amp;gt;
&amp;lt;hr&amp;gt;&amp;lt;center&amp;gt;nginx/1.16.0&amp;lt;/center&amp;gt;
&amp;lt;/body&amp;gt;
&amp;lt;/html&amp;gt;

Files

Screenshot from 2021-04-01 09-09-09.png (47.8 KB) Screenshot from 2021-04-01 09-09-09.png Viktor Gurov, 04/01/2021 01:14 AM
Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next
Actions
Copy link
 #3

Updated by Jim Pingle over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Target version changed from CE-Next to 2.6.0

PR was merged yesterday.

Actions
Copy link
 #4

Updated by Jim Pingle over 3 years ago

  • Plus Target Version set to 21.05
Actions
Copy link
 #5

Updated by Jim Pingle over 3 years ago

Already in 21.05 branch.

Actions
Copy link
 #6

Updated by Jim Pingle over 3 years ago

  • Target version changed from 2.6.0 to 2.5.2
Actions
Copy link
 #7

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Closed
  • Assignee set to Viktor Gurov
  • % Done changed from 0 to 100

Since the bug causing the original notice was random and hard to reproduce, and also has been fixed, it's not viable to test the exact original scenario.

It does appear to be working correctly now with a similarly crafted manual notice, though.

Actions
Copy link

Also available in: Atom PDF