Project

General

Profile

Actions

Bug #11842

closed

Captive Portal post-auth redirect is not properly respected

Added by Jim Pingle 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Captive Portal
Target version:
Start date:
04/22/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
All
Affected Architecture:

Description

The value of "After authentication Redirection URL" in Captive Portal is supposed to override the automatically detected browser request URL so that the user is forced to go to that destination. This is the behavior stated under the field in the GUI. It is not a value of last resort.

Currently the code is not respecting that behavior.

While here, the redirect code handling is a bit of a mess and needs fixed up in general.

Actions #1

Updated by Jim Pingle 5 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Gertjan KROEB 5 months ago

A feedback :

I saw my browser sending 'plain http' to the https port.

File /etc/inc/captiveportal.inc line 2261 :

$protocol = (isset($cpcfg['httpslogin'])) ? 'https://' : 'http://';

$cpcfg is assigned a couple of lines lower, line 2275 :

$cpcfg = $config['captiveportal'][$cpzone];

I put this line before line 2261 and all is well.

edit : is it ok to leave message like this over here ?

Actions #3

Updated by Jim Pingle 5 months ago

  • Status changed from Feedback to In Progress

I'll look into that ASAP, thanks for testing!

Actions #4

Updated by Jim Pingle 5 months ago

  • % Done changed from 100 to 90
Actions #5

Updated by Jim Pingle 5 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100
Actions #6

Updated by Jim Pingle 4 months ago

  • Plus Target Version set to 21.05
Actions #7

Updated by Jim Pingle 4 months ago

Already in 21.05 branch.

Actions #8

Updated by Jim Pingle 4 months ago

  • Target version changed from 2.6.0 to 2.5.2
Actions #9

Updated by Jim Pingle 4 months ago

  • Status changed from Feedback to Closed
Actions

Also available in: Atom PDF