XMLRPC client improvements
Plus Target Version:
There are a few changes that could be beneficial for the XMLRPC sync client:
- The same client can be reused for multiple queries. Though it already appears that the PHP XML RPC code helps this along, it's more logical to make it explicit in the code.
- Currently the code retries once and alerts on every failure. It makes more sense to retry a couple more times but only alert if every attempt fails. Intermittent errors can be logged, but don't necessitate an alert for each failure.
- The XMLRPC error caught from
XML_RPC2_CurlExceptionis not properly printing its error message, it is printing an empty string, but we may want to preserve the existing behavior and only choose an alternate method if that is empty.
To me, I already have a set of changes ready to implement these.