Project

General

Profile

Actions
Copy link

Regression #12550

closed
JP VG

PHP ``foreach`` error in IPsec status

Regression #12550: PHP ``foreach`` error in IPsec status

Added by Jim Pingle almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
IPsec
Target version:
2.6.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Force Exclusion
Affected Version:
2.6.0
Affected Architecture:

Description

In rare occasions I have hit a PHP error from the IPsec status page, though I haven't managed to replicate it on demand yet.

[30-Nov-2021 12:59:47 America/New_York] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/www/status_ipsec.php on line 117

Probably easy to fix with an isset + is_array check before the foreach.

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #2

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov

VG Updated by Viktor Gurov almost 5 years ago Actions
Copy link
 #3

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:f3554a3cf7d96888ead723b5ad7c3c86e327d2a8.

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #4

  • Release Notes changed from Default to Force Exclusion

This was a bug with new code added after the last release, so no need for it to be in the release notes.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved

No sign of this since the fix went in.

Actions
Copy link

Also available in: Atom