Actions
Bug #12713
closedPHP error on ``pkg_mgr_install.php`` when multiple instances are running
Start date:
Due date:
% Done:
100%
Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
Affected Architecture:
Description
There is a PHP syntax error causing an error in pkg_mgr_install.php
which gets triggered if multiple pkg
processes are attempting to run at the same time:
PHP Warning: sprintf(): Too few arguments in /usr/local/www/pkg_mgr_install.php on line 667 PHP Warning: gettext() expects exactly 1 parameter, 2 given in /usr/local/www/pkg_mgr_install.php on line 668
The code in question is:
/*
* If pfSense-upgrade failed to run, present log to user
*/
if ($another_instance) {
$failmsg = gettext(sprintf("Another instance of %s " .
"is running. Try again later"),
$g['product_name'] . "-upgrade");
} elseif (!$start_polling) {
The parenthesis are incorrect in the sprintf
call, both should be after -upgrade"
.
Updated by Jim Pingle over 2 years ago
- Status changed from New to Pull Request Review
Updated by Jim Pingle over 2 years ago
- Status changed from Pull Request Review to Feedback
- Target version set to 2.6.0
- Plus Target Version set to 22.01
Merged and picked for 22.01/2.6.0
Updated by Jim Pingle over 2 years ago
- % Done changed from 0 to 100
Applied in changeset f73ace96e837ca2f0957a5fafe5794e033231c2e.
Updated by Jim Pingle over 2 years ago
- Status changed from Feedback to Resolved
This was tricky to make happen on purpose before, but the correct syntax is present in the repo now so the PHP error couldn't happen with the current code.
Actions