Project

General

Profile

Actions
Copy link

Feature #13017

open

Packet capture: add preview results while capture is running

Added by Phil Wardt 12 months ago. Updated about 3 hours ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
Marcos M
Category:
Packet Capture
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default

Description

Packet Capture: add preview results
- allow preview results while a capture is still running
- add a capture summary field
- count: if empty value, properly set it to default 100 instead of 0
- do not pass empty argument to tcpdump when no filter options are posted
- do not check form validity when clicking other buttons than start
- more compact GUI (spannable help tool tips)
- info changes and fixes

Patch for pfsense 2.6.0 attached
Github commit in comments

Files

Download all files
diag_packet_capture.patch (15.8 KB) diag_packet_capture.patch Phil Wardt, 04/01/2022 03:52 PM
01-Start.JPG (209 KB) 01-Start.JPG Phil Wardt, 04/01/2022 03:54 PM
02-Wait.JPG (208 KB) 02-Wait.JPG Phil Wardt, 04/01/2022 03:54 PM
03-Results.JPG (293 KB) 03-Results.JPG Phil Wardt, 04/01/2022 03:54 PM
diag_packet_capture-v4.patch (15.8 KB) diag_packet_capture-v4.patch Phil Wardt, 04/02/2022 04:25 AM
diag_packet_capture-v6.patch (16.8 KB) diag_packet_capture-v6.patch Phil Wardt, 04/03/2022 05:02 AM
diag_packet_capture-v6-master.patch (16.6 KB) diag_packet_capture-v6-master.patch Phil Wardt, 04/09/2022 11:07 AM

Related issues

Related to Feature #13382: More flexible packet capture GUIPull Request ReviewMarcos M

Actions
Actions
Copy link
 #1

Updated by Phil Wardt 12 months ago

Commit:
https://github.com/pfsense/pfsense/pull/4567

Note: I added the -U option to unbuffer output and permit results display while it still runs

Actions
Copy link
 #2

Updated by Phil Wardt 12 months ago

Fix upstream original version not applying "DNS resolution" option during capture, but only during display
patch for pfsense 2.6.0 attached

Actions
Copy link
 #3

Updated by Phil Wardt 12 months ago

Fix previous patch did not properly apply dns option during view/preview results
Add a warning that running preview with dns option can be slow

Actions
Copy link
 #4

Updated by Phil Wardt 12 months ago

If it makes testing easier, here's attached a patch that applies to the current master branch

Actions
Copy link
 #5

Updated by Marcos M about 3 hours ago

Actions
Copy link
 #6

Updated by Marcos M about 3 hours ago

  • Status changed from New to Pull Request Review
  • Assignee set to Marcos M

Thank you for the pull request. This has been implemented with a re-write of the Packet Capture page. See https://redmine.pfsense.org/issues/13382

Actions
Copy link
 #7

Updated by Marcos M about 3 hours ago

  • % Done changed from 100 to 0
Actions
Copy link

Also available in: Atom PDF