Feature #13384
closed
When Adding / Editing a Firewall Rule, the Interface option should default to the Interface from which you clicked on the Add/Edit link
0%
Description
As a system admin adding/editing a Firewall Rule
I want to Add/Edit a Firewall Rule specifically against the Interface that I have navigated from before clicking the Add/Edit Rule button
So that I don't incorrectly assign the Firewall Rule to the wrong Interface
Given I am on the Firewall > Rules > {Network X} page
When I click on Add Firewall Rule, or Edit Existing Firewall Rule
Then I go through to the "firewall_rules.php?if=opt2" page
When I view the "Interface" input box (The one with this helper text beneath "Choose the interface from which packets must come to match this rule.")
Then it should default to OP2 (in this example), aka the Interface from which I choose to Add/Edit a rule on
Then I can make sure that I am only Adding/Editing the rule on the Interface it belongs and I can't accidentally Add/Edit a rule and it gets incorrectly assigned to the wrong Interface
Note: Seems to be this section of code: https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/firewall_rules_edit.php#L1316
Updated by Jim Pingle almost 3 years ago
- Status changed from New to Rejected
I can't replicate what you are stating here.
If I go to any given tab in firewall rules and add a new rule or edit a rule, the correct interface is selected automatically.
There may be a browser plugin or script you have that is interfering but as far as I can tell it's working exactly as you want now, unless there is some aspect of your procedure that isn't clear.
If you can still reproduce it in a clean browser and a clean install of the latest version of pfSense Plus or CE, please list each step taken exactly with what you clicked and where.
Updated by Michael Cropper almost 3 years ago
@Jim Pingle
It does indeed select the correct interface. What I'm saying is that it should not allow this to be a selectable option. It's confusing by having the dropdown. A user has clicked through to this page from the interface, why would they want to create a firewall rule for another interface? If they wanted that, they would click into the other interface first, then they would click to add/edit a rule on that interface.
User experience improvements can go a long way to help people in the system.
Updated by Jim Pingle almost 3 years ago
Just because they hit the add button there doesn't mean it should be restricted. It's to add a rule, period. It defaults to the current interface but the user may want to add a rule somewhere else. It's up to them.
Unnecessarily limiting user choices isn't good UX either.