Project

General

Profile

Actions

Bug #14052

closed

Bridge interface is not properly validated when submitted on ``interfaces_bridge_edit.php``

Added by Jim Pingle over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Interfaces
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.05
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

When creating or editing a bridge interface on interfaces_bridge_edit.php, the submitted $_POST['bridgeif'] is used in interface_bridge_configure() before it is validated. Subsequently, that function calls others which in turn use the submitted interface name in shell commands.

Due to a lack of escaping on commands in the functions being called, it is possible to execute arbitrary commands with a properly formatted submission value for $_POST['bridgeif'] such as "; touch somefile; #".

Actions #1

Updated by Jim Pingle over 1 year ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to Resolved

I can't get any problematic input past the new input validation. Looks solid to me.

Actions #3

Updated by Jim Pingle over 1 year ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF