Project

General

Profile

Bug #146

Missing validation for alias usage

Added by Chris Buechler almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
Start date:
11/08/2009
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

Aliases are allowed to be used in several ways that breaks the ruleset.

firewall_nat_edit.php needs a check to only allow a single IP host alias. firewall_aliases_edit.php needs a check to not allow adding IPs to an alias used in a port forward entry.

Host and network aliases can be entered in the Port box, and port aliases in the src/dst boxes. They don't show up in autocompletion, but are used if name is typed in manually, breaking the ruleset.

Associated revisions

Revision 72cb5baf (diff)
Added by Ermal Luçi almost 10 years ago

Ticket #146. Fix the autocompletion of ports aliases only for the ports and host/network aliases for the src/dst. Checking if a valid alias is entered end if it is a correct one for this box seems like to much overhead and work for this.

Revision b6867d81 (diff)
Added by Ermal Luçi almost 10 years ago

Ticket #146. Fix the autocompletion of ports aliases only for the ports and host/network aliases for the src/dst. Checking if a valid alias is entered end if it is a correct one for this box seems like to much overhead and work for this. (For firewall_nat_edit.php)

Revision 1e578a7f (diff)
Added by Ermal Luçi almost 10 years ago

Resolves #146 Add propper validation on alias usage. Allow port type aliases only on port side and other aliases in ip specifications and similar. Introduce a new function is_portoralias to ressemble the is_ipaddroralias to check for the cases.

Revision 9b45f821 (diff)
Added by Ermal Luçi almost 10 years ago

Ticket #146 Fix typos ansd copy/pasto errors.

Revision 984c64a4 (diff)
Added by Ermal Luçi almost 10 years ago

Add the same checks to the aliases import functionality as the ones that are done during creation/editing of aliases. Ticket #146

History

#1 Updated by Ermal Luçi almost 10 years ago

  • % Done changed from 0 to 70

#2 Updated by Ermal Luçi almost 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 70 to 100

#3 Updated by Chris Buechler almost 10 years ago

  • Status changed from Resolved to Feedback
  • Target version set to 2.0

needs testing

#4 Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF