Project

General

Profile

Actions

Feature #14793

closed

Package: sfpnfo, SFP Information

Added by Marco Goetze about 1 year ago. Updated about 1 year ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
New Package Request
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:

Description

Submitted a PR for a Package displaying Information about inserted SFP / SFP+ Modules in a easy to access way in the Webinterface under Menu > Status > SFP Info.

Pull Request: https://github.com/pfsense/FreeBSD-ports/pull/1294

Screenshot:
Screenshot


Files

20230919_171939.png (74 KB) 20230919_171939.png Screenshot Marco Goetze, 09/19/2023 03:20 PM
Actions #1

Updated by Jim Pingle about 1 year ago

  • Status changed from New to Rejected

This is not needed. SFP information is already printed on Status > Interfaces. If more detail is needed the additional fields could be added there rather than making a whole separate package for it.

Actions #2

Updated by Marco Goetze about 1 year ago

I have a totally different opinion on this, the existing interface output is cluttered and not showing all needed information. We run dozed of pfSense systems remotely where this view would be a nice addon. I didnt make a PR to add this to the main functionality it is a Package so people can decide if they want to use it or not. Just a reject without any further discussion on this... common it is a package not a core function.

Actions #3

Updated by Marco Goetze about 1 year ago

And just double checked Jim Pingle in scenarios like having a LAG the Mentioned Interface Status is not displaying any SFP information at all.

So as said, it is a optional package, dont see why this should be rejected completely.

Actions #4

Updated by Marco Goetze about 1 year ago

Jim Pingle wrote in #note-1:

This is not needed. SFP information is already printed on Status > Interfaces. If more detail is needed the additional fields could be added there rather than making a whole separate package for it.

Jim Pingle please do not just ignore this. Reject in minutes but not even answering valid points, this is not how open source should work.

Actions #5

Updated by Jim Pingle about 1 year ago

If status_interfaces.php is insufficient in some way, the correct thing to do would be to fix or otherwise improve that page, proposing changes and getting approval before any development work. Having an entire extra package adds technical debt and unnecessarily complicates the process.

Actions #6

Updated by Marco Goetze about 1 year ago

This reason is valid and true. I will think about starting a suggestion on how to improve the interface list.
Thank you

Actions

Also available in: Atom PDF