Project

General

Profile

Bug #153

Removing proxy ARP VIP doesn't kill off choparp

Added by Chris Buechler over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Virtual IPs
Target version:
Start date:
11/15/2009
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

When a proxy ARP VIP is removed, its choparp is left running. This appears to be because:
1) When saving changes and running interface_proxyarp_configure() the VIP is still set in the configuration
2) When applying changes, this bit of code:

    if ($_POST['apply']) {
        if ($a_vip[$_POST['id']]) {
                switch ($a_vip[$_POST['id']]['mode']) {
                case "ipalias":
                        interface_ipalias_configure($a_vip[$_POST['id']]);
                        break;
                case "proxyarp":
                        interface_proxyarp_configure();
                        break;

Gets called, but the cases fail, it doesn't have the mode anymore at that point so interface_proxyarp_configure isn't called. Manually calling interface_proxyarp_configure(); after applying changes does kill off choparp properly.

Associated revisions

Revision 5d5ec271 (diff)
Added by Ermal Luçi over 9 years ago

Resolves #153 Treat proxyarp special case during deletion.

Revision d9d95b0a (diff)
Added by Ermal Luçi over 9 years ago

Revert "Resolves #153 Treat proxyarp special case during deletion."

This reverts commit 5d5ec271de58dd8306fa7bacfb439b07b3dd2e51.

Revision 607b1c39 (diff)
Added by Sjon Hortensius about 4 years ago

Rewrote xhr javascript, applied .form-inline refs #153

History

#1 Updated by Ermal Luçi over 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#2 Updated by Chris Buechler over 9 years ago

  • Status changed from Resolved to New
  • % Done changed from 100 to 0

This still doesn't properly kill choparp. I think now because the vip is unset before the function gets called, so again the proxyarp case isn't called.

#3 Updated by Ermal Luçi over 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#4 Updated by Ermal Luçi over 9 years ago

This is the right commit.

cc76d08dcc63b628eb548201454341f21d8c56b3

#5 Updated by Chris Buechler over 9 years ago

this works now, thanks!

Also available in: Atom PDF