Bug #15443
closed
PHP Crash: pfBlockerNG/DNSBL/DNSBL Groups, attempt to add list
0%
Description
Clicking Add to add a new list causes a PHP fatal error. Reproducible crash. Two copies of crash screenshots and PHP_errors.log attached.
I was working on configuring pfblockerng.
Files
| php-crash.png (132 KB) php-crash.png | |||
| PHP_errors.log (395 Bytes) PHP_errors.log | |||
| crash2.png (135 KB) crash2.png | |||
| PHP_errors2.log (790 Bytes) PHP_errors2.log |
Updated by Jeff Earickson 10 days ago
pfblockerng version 3.2.0_9. Same bug happens on a Netgate 1100 running 24.03_1 as well. Looks like duplicate of Bug 15365, just found this entry in redmine.
In looking at https://www.php.net/manual/en/function.range.php, and the code at line 391, it looks like an increasing range is asked for, yet the code has a negative step, which makes no sense. It says "step may be negative for decreasing ranges". My guess that between PHP 8.2 and 8.3, the coders fixed this misfeature to not allow for negative numbers in increasing ranges.
I moved the original file aside, edited line 391 to change the step sizes to 1, and retried the webpage. It worked, no crash. I did not try to actually add another list. This "fix" may not actually be correct. Bug 15365 suggests this same fix.
Updated by Jim Pingle 9 days ago
- Project changed from pfSense Plus to pfSense Packages
- Category changed from PHP Interpreter to pfBlockerNG
- Release Notes deleted (
Default)
Updated by Jeff Earickson 9 days ago
Plus mark this as a dup of bug 15365 (and close I guess). I tried Christopher Cope's fix (two spots in the file) and things worked for me on the 2100. I could add my list as desired.