Project

General

Profile

Actions

Bug #15857

open

FRR BGP generates an invalid config when peer group with a space in its name is used

Added by Andrew Collings about 1 month ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
FRR
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
2.7.2
Affected Plus Version:
24.03
Affected Architecture:
amd64

Description

When creating a peer group by going to Services > FRR BGP > Neighbors > Add and entering a name to create a peer group, then selecting that peer group when creating a neighbor, FRR as a whole no longer functions. I didn't see any information in system logs with FRR logging enabled but when going to the shell and attempting to start FRR manually, it indicates that there was an unknown command on the line of the config where the peer group is referenced. After changing the name to use an underscore rather than a space FRR starts working again. There's no indication in the web UI that names can't contain spaces, nor does it stop you from entering a name with a space like most of the rest of the pfSense UI does. It occurred to me after the fact that it was a bad idea to use a name with a space anyway, but it would be nice to remove the foot gun by adding a note under the text entry field and validating that the name doesn't contain a space. This is especially true since the minimal logging for FRR makes the issue non-obvious for users. The issue only occurs when the peer group is referenced by a neighbor - just creating a peer with a space in the name doesn't cause a problem. I've reproduced the behavior on both CE and Plus.

No data to display

Actions

Also available in: Atom PDF